mosquitto: update to 1.6.12 #4191

ymartin59 · 2020-09-26T12:29:47Z

Motivation: Update and publish for geminilake
Linked issues: #4044, #3225

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

hgy59 · 2020-09-29T07:02:05Z

~~@ymartin59 maybe we should first build and publish mosquitto version 1.6.10 as this is the least one that supports ppc853x,~~

ymartin59 · 2020-10-03T07:52:33Z

@hgy59 Thanks for your help. You did a great job... my draft was far not enough but I have been stopped in my testing.

hgy59 · 2020-10-03T09:02:14Z

@ymartin59 do you benefit from the artifacts created by the github build actions?
For this we need a solution to skip packages that are expected to fail (ffsync in this PR).

ymartin59 · 2020-10-03T17:14:21Z

@hgy59 No, I rebuild locally after merge and test on xpenology before uploading and activating version in repository.

- updated libwebsockets - fix clock_gettime for arm5 and older ppc - install mosquitto_rr too - update icon

ymartin59 · 2020-10-04T06:16:38Z

@hgy59 Simply does not build:

-- Compiled with LWS_WITH_DIR and LWS_WITH_DIR
-- CMAKE_TOOLCHAIN_FILE=''
Git commit hash: pre-dsm6-550-gc8e9dda4
Compiling with SSL support
CMake Error at /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY) (found
  version "1.1.1d")
Call Stack (most recent call first):
  /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.13/Modules/FindOpenSSL.cmake:412 (find_package_handle_standard_args)
  CMakeLists.txt:1723 (find_package)


-- Configuring incomplete, errors occurred!
See also "/spksrc/spk/mosquitto/work-x64-6.1/libwebsockets-3.2.2/build/CMakeFiles/CMakeOutput.log".
See also "/spksrc/spk/mosquitto/work-x64-6.1/libwebsockets-3.2.2/build/CMakeFiles/CMakeError.log".

hgy59 · 2020-10-04T09:01:39Z

-- Configuring incomplete, errors occurred!
See also "/spksrc/spk/mosquitto/work-x64-6.1/libwebsockets-3.2.2/build/CMakeFiles/CMakeOutput.log".
See also "/spksrc/spk/mosquitto/work-x64-6.1/libwebsockets-3.2.2/build/CMakeFiles/CMakeError.log".

But the gh build action succeeded to build (only ffsync failed).

The same on my local clone. It builds successfully with this docker image:
synocommunity/spksrc latest 73698c0751c0 3 months ago 877MB

Something must be different in your build environment.

parts of configure libwebsockets:

-- Compiled with LWS_WITH_DIR and LWS_WITH_DIR
-- The C compiler identification is GNU 4.9.3
-- Check for working C compiler: /spksrc/toolchains/syno-x64-6.1/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc
-- Check for working C compiler: /spksrc/toolchains/syno-x64-6.1/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- CMAKE_TOOLCHAIN_FILE=''
-- Found Git: /usr/bin/git
fatal: No names found, cannot describe anything.
Git commit hash:
-- Performing Test LWS_HAVE_inline
-- Performing Test LWS_HAVE_inline - Success

...

-- Performing Test LWS_GCC_HAS_TYPE_LIMITS - Success
Compiling with SSL support
-- Found OpenSSL: /spksrc/spk/mosquitto/work-x64-6.1/install/var/packages/mosquitto/target/lib/libcrypto.so (found version "1.0.2u")
OpenSSL include dir: /spksrc/spk/mosquitto/work-x64-6.1/install/var/packages/mosquitto/target/include
OpenSSL libraries: /spksrc/spk/mosquitto/work-x64-6.1/install/var/packages/mosquitto/target/lib/libssl.so;/spksrc/spk/mosquitto/work-x64-6.1/install/var/packages/mosquitto/target/lib/libcrypto.so
-- Looking for openssl/ecdh.h
-- Looking for openssl/ecdh.h - found

ymartin59 · 2020-10-04T19:08:16Z

@hgy59 I probably have explanation: I have rebased branch to get "fixed" openssl but its install command fails to provide pkgconfig requires by CMake: cbda607

hgy59 · 2020-10-10T12:31:45Z

I hope this fixes #4210 , at least the compiler flags are now fixed with this small adjustment.
Error might be introduced by some framework changes...

hgy59 · 2020-10-10T15:53:55Z

@ymartin59 as @arnebjarne has confirmed that #4210 is fixed, I removed the respective labels here.

May a propose to merge this immediately to have a working version of openssl v1.0.1u on the master branch?

After that, we can rebase #4155 (and #4195, and maybe other PRs) and hopefully merge #4155 soon.

- remove openssl.cnf from PLIST as it was removed by using installed /etc/ssl/openssl.cnf

arnebjarne · 2020-10-11T03:43:09Z

Hi hgy59. SPK_REV = 10 Since it is already released (I got the package via DSM). Itsnt it better to bump it to 11, so people who have installed v10 get an update? Br, Bjarne

…

________________________________ Fra: hgy59 <notifications@github.com> Sendt: Sunday, October 11, 2020 12:45:19 AM Til: SynoCommunity/spksrc <spksrc@noreply.github.com> Cc: Bjarne Saltbaek <arnebjarne72@hotmail.com>; Mention <mention@noreply.github.com> Emne: Re: [SynoCommunity/spksrc] mosquitto: update to 1.6.12 (#4191) Merged #4191<#4191> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#4191 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAGLOC2YYJY6XUFJFCTKOD3SKDPX7ANCNFSM4R233VZQ>.

hgy59 · 2020-10-11T09:20:33Z

@arnebjarne good catch, I didn't realize the version 1.6.12-10 was already pushed to the repo.

Anyway the current version is not ready to push, as the update shall include openssl 1.1.1 with #4155 (update done on the branch with 46a7931).

hmueller01 · 2020-10-11T12:43:00Z

I installed 1.6.12-10 on my RS816 (Armada 385 CPU, DSM 6.2.3-25426 Update 2) and had same problem with websockets. Commenting out the use of Websockets in the config solves this problem (which is hopefully fixed with #4210) and mosquitto starts without errors. But unfortunately the daemon does not run in background. Switching back to 1.4.14-9 make mosquitto work again. Not sure if the fix #4210 helps something in my case ...

Starting mosquitto command /volume1/@appstore/mosquitto/sbin/mosquitto -d -c /volume1/@appstore/mosquitto/var/mosquitto.conf 
1602337331: Loading config file /usr/local/mosquitto/etc/mosquitto/conf.d/local.conf

> ps aux|grep mosquitto gives not result.

arnebjarne · 2020-10-11T14:53:43Z

@arnebjarne good catch, I didn't realize the version 1.6.12-10 was already pushed to the repo.

Anyway the current version is not ready to push, as the update shall include openssl 1.1.1 with #4155 (update done on the branch with 46a7931).

Hmm strange. I can compile mosquitto 1.6.12-11 with openssl 1.1.1.h.

How:
git clone https://github.com/SynoCommunity/spksrc.git
cd spksrc/
git remote add openssl https://github.com/th0ma7/spksrc.git
git merge openssl/openssl-102u
cd spk/mosquitto/
make arch-rtd1296

works for me :)

So you are waiting for the openssl 1.1.1 pull request to be commited into the master branch?

hgy59 · 2020-10-11T15:54:17Z

Hmm strange. I can compile mosquitto 1.6.12-11 with openssl 1.1.1.h.

@arnebjarne sorry, I removed the comment that libwebsocket fails to build (probably was an issue on another branch I am currently working).

EDIT:
It fails only for arch-ppc853x-5.2

ymartin59 mentioned this pull request Sep 26, 2020

Update Mosquitto to 1.6.9 #4068

Closed

3 tasks

ymartin59 force-pushed the 4044_update_mosquitto branch 2 times, most recently from c2cd2c0 to efc4de3 Compare September 27, 2020 17:00

ymartin59 and others added 6 commits October 4, 2020 07:59

mosquitto: update to 1.6.12

548e1e8

fix configure options (similar to SynoCommunity#4196)

c4351a5

my changes not already commited on SynoCommunity#4068

c619b3a

- updated libwebsockets - fix clock_gettime for arm5 and older ppc - install mosquitto_rr too - update icon

since mosquitto 1.6.11 ppc853x is not supported anymore

bbeb54c

use current config file

63e58ae

support ppc853x by patch

c8e9dda

Fix openssl install for CMake to detect it

cbda607

ymartin59 force-pushed the 4044_update_mosquitto branch from 2dd373f to cbda607 Compare October 4, 2020 09:15

ymartin59 added bug status/do-not-merge status/work-in-progress labels Oct 10, 2020

fix make options SynoCommunity#4210

56017ce

hgy59 added status/ready-to-merge and removed bug status/do-not-merge status/work-in-progress labels Oct 10, 2020

hgy59 mentioned this pull request Oct 10, 2020

Fall 2020 security package update #4211

Closed

55 tasks

final fix for openssl 1.0.1

41dafdf

- remove openssl.cnf from PLIST as it was removed by using installed /etc/ssl/openssl.cnf

hgy59 merged commit df01989 into SynoCommunity:master Oct 10, 2020

hgy59 added satus/do-not-publish package is not yet ready to publish and removed status/ready-to-merge labels Oct 11, 2020

ymartin59 added status/to-publish and removed satus/do-not-publish package is not yet ready to publish labels Oct 12, 2020

ymartin59 deleted the 4044_update_mosquitto branch October 12, 2020 15:24

hgy59 mentioned this pull request Oct 25, 2020

Mosquitto package not available through the package center #4044

Closed

ymartin59 removed the status/to-publish label Oct 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mosquitto: update to 1.6.12 #4191

mosquitto: update to 1.6.12 #4191

ymartin59 commented Sep 26, 2020 •

edited by hgy59

Loading

hgy59 commented Sep 29, 2020 •

edited

Loading

ymartin59 commented Oct 3, 2020

hgy59 commented Oct 3, 2020

ymartin59 commented Oct 3, 2020

ymartin59 commented Oct 4, 2020

hgy59 commented Oct 4, 2020

ymartin59 commented Oct 4, 2020

hgy59 commented Oct 10, 2020

hgy59 commented Oct 10, 2020

arnebjarne commented Oct 11, 2020 via email

hgy59 commented Oct 11, 2020 •

edited

Loading

hmueller01 commented Oct 11, 2020

arnebjarne commented Oct 11, 2020 •

edited

Loading

hgy59 commented Oct 11, 2020 •

edited

Loading

mosquitto: update to 1.6.12 #4191

mosquitto: update to 1.6.12 #4191

Conversation

ymartin59 commented Sep 26, 2020 • edited by hgy59 Loading

Checklist

hgy59 commented Sep 29, 2020 • edited Loading

ymartin59 commented Oct 3, 2020

hgy59 commented Oct 3, 2020

ymartin59 commented Oct 3, 2020

ymartin59 commented Oct 4, 2020

hgy59 commented Oct 4, 2020

ymartin59 commented Oct 4, 2020

hgy59 commented Oct 10, 2020

hgy59 commented Oct 10, 2020

arnebjarne commented Oct 11, 2020 via email

hgy59 commented Oct 11, 2020 • edited Loading

hmueller01 commented Oct 11, 2020

arnebjarne commented Oct 11, 2020 • edited Loading

hgy59 commented Oct 11, 2020 • edited Loading

ymartin59 commented Sep 26, 2020 •

edited by hgy59

Loading

hgy59 commented Sep 29, 2020 •

edited

Loading

hgy59 commented Oct 11, 2020 •

edited

Loading

arnebjarne commented Oct 11, 2020 •

edited

Loading

hgy59 commented Oct 11, 2020 •

edited

Loading