Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate zeromq (libzmq) #4254

Merged
merged 8 commits into from
Nov 4, 2020
Merged

Remove duplicate zeromq (libzmq) #4254

merged 8 commits into from
Nov 4, 2020
+12 −46

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Nov 3, 2020 •
edited
Loading

Motivation: Exists two version of zeromq also called libzmq. Keep only the latest version, update to use the latest version available online (4.3.3) and use the zeromq naming to limit dependency changes over other packages.
Linked issues: N/A

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@hgy59
Copy link
Contributor

hgy59 commented Nov 3, 2020 •
edited
Loading

@th0ma7 please keep the package name for the folder (use cross/libzmq) dispite of the dependency changes.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 3, 2020 •
edited
Loading

@th0ma7 please keep the package name for the folder (use cross/libzmq) dispite of the dependency changes.

@hgy59 done, pending action build to confirm all ok.
Indirectly relates to #4255 where I noticed the duplication of zeromq and libzmq.

@th0ma7 th0ma7 self-assigned this Nov 3, 2020
@th0ma7 th0ma7 requested a review from hgy59 November 3, 2020 11:43
@hgy59
Copy link
Contributor

hgy59 commented Nov 3, 2020

@th0ma7 you might remove cross/libsodium as it was referenced only by cross/zeromq.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Nov 4, 2020

@th0ma7 you might remove cross/libsodium as it was referenced only by cross/zeromq.

@hgy59 good catch but to the contrary I've re-enabled encryption support through libsodium to keep previous behavior, now using cmake instead.

This was referenced Nov 4, 2020
Merged
Closed
@hgy59 hgy59 merged commit 03bbf37 into SynoCommunity:master Nov 4, 2020
@th0ma7 th0ma7 deleted the zeromq-fix branch April 23, 2021 15:02
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
@th0ma7
Remove duplicate zeromq (libzmq) (SynoCommunity#4254)
e05527f 
* zeromq: Use libzmq cmake build process and update to version 4.3.3
* zeromq: Remove previous libzmq and rename zeromq to libzmq
* ffmpeg: Use zeromq instead of libzmq
* libzmq: re-enable encryption support with libsodium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59 hgy59 approved these changes

Assignees

@th0ma7 th0ma7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th0ma7 @hgy59