Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icecast: update dependencies and update for DSM7 #4628

Merged
merged 8 commits into from
May 30, 2022
Merged

icecast: update dependencies and update for DSM7 #4628

merged 8 commits into from
May 30, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented May 11, 2021 •
edited
Loading

Motivation: Icecast needs an update due to several security fixes
Linked issues: depends on #4625 and #4626

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@hgy59 hgy59 mentioned this pull request May 11, 2021
Open
ymartin59
ymartin59 requested changes May 14, 2021
View reviewed changes
Copy link
Contributor

@ymartin59 ymartin59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but I think it is required to support "var" relocation seamlessly for users

spk/icecast/Makefile Outdated Show resolved Hide resolved
@hgy59 hgy59 changed the title update icecast dependencies and update for DSM7 icecast: update dependencies and update for DSM7 May 16, 2021
@hgy59 hgy59 force-pushed the update_icecast branch from b3566ae to ad545a9 Compare July 4, 2021 20:30
@nmiller0113
Copy link

Does anyone know when this may get merged? I'd love to get this working on DSM 7

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 3, 2022

@nmiller0113 you are welcome to test the current packages built by github build action (download packages.zip artifacts of the latests build action of this PR).
i never streamed music with icecast, only tested the web UI

@nmiller0113
Copy link

nmiller0113 commented Jan 3, 2022 •
edited
Loading

@nmiller0113 you are welcome to test the current packages built by github build action (download packages.zip artifacts of the latests build action of this PR). i never streamed music with icecast, only tested the web UI

Thanks @hgy59 but I'm not sure I know how to do that. I have just been running the package install from my Synology desktop previously. Even if I download it, not sure of the proper way to instal it from the Synology CLI. If you have a place to point me to read about how to, I'd be more than happy to test it. Thanks!

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 4, 2022

Even if I download it, not sure of the proper way to instal it from the Synology CLI. If you have a place to point me to read about how to, I'd be more than happy to test it. Thanks!

You can manually install spk files in the DSM package center of your diskstation. You don't need any ssh terminal nor cli commands.

In the github build action page (reachabel via Checks tab above) you navigate to Artifacts to download packages.
You can only download packages.zip containing all spk files successfully built by one github action.
As we mostly create packages for generic archs you have to know the generic arch of your DS model to identify the correct spk file. You find the information on our wiki page package architectures.
In the package center you find the manual installallation button right of the search field. Here you can choose a local spk file to install.

Such installations are compatible with installations from the synocommunity repo. i.e. you will get notified, when a newer version is available in the repo and you can update it.

Only in the case of errors with a package, you have to ssh into the diskstation to analyze log files etc.

@misaka00251
Copy link

Just asking, when will this get merged? Is it not ready or still under review?

hgy59 added 4 commits May 29, 2022 14:20
@hgy59
update icecast dependencies and update for DSM7
979c1a8 
- adjust package paths in icecast.xml (avoid use of /usr/local/{package})
- update ezstream to v1.0.2 (and add cross/libcheck for build)
- update taglib to v1.12
- install favicon.ico
- add ezstream cli tools to path (SPK_COMMANDS)
@hgy59
cleanup makefile
36de32f
@hgy59
install and configure custom mime.types file
21044bb 
- provide mime.types for file serving
- use dsm 7 compatible var folder
@hgy59
optimize code
bc01c7f 
- optimize code of icecast and ezstream
- update changelog as openssl is updated too
@hgy59 hgy59 force-pushed the update_icecast branch from aeb06eb to bc01c7f Compare May 29, 2022 13:12
hgy59 added 4 commits May 30, 2022 00:42
@hgy59
build only shared libraries of cross/speex
4acfa4d 
- without the build of static libraries the binaries are not built and libogg is not required
@hgy59
disable build of static libraries
72e0467 
- static libraries are obsolete here
@hgy59
update cross/libshout
8562619
@hgy59
icecast: add service port
96ea1f1 
- add service port to create firewall rules
- define DSM UI url for admin page
@hgy59
Copy link
Contributor Author

hgy59 commented May 29, 2022

Just asking, when will this get merged? Is it not ready or still under review?

Finally I was able to test icecast. Except the large latency (as by design) a sample stream worked as expected.

@hgy59 hgy59 merged commit a88af71 into SynoCommunity:master May 30, 2022
@hgy59 hgy59 deleted the update_icecast branch May 30, 2022 04:41
@hgy59 hgy59 added status/published Published and activated (may take up to 48h until visible in DSM package manager) and removed status/published Published and activated (may take up to 48h until visible in DSM package manager) labels May 30, 2022
@hgy59 hgy59 mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymartin59 ymartin59 ymartin59 approved these changes

Assignees
No one assigned
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hgy59 @nmiller0113 @misaka00251 @ymartin59