Add java-11-openjdk #4784

arnebjarne · 2021-08-15T15:05:41Z

Motivation: Java is missing from repo.
Linked issues: #4773

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

spk/java-11-openjdk/Makefile

…e/spksrc into openjdk-with-missing-digests

hgy59 · 2021-08-15T23:38:10Z

wow, a lot of work!

some overall suggestions:
it is not worth to generate and include documentation (man pages, pdf, html, ps, ...) in the packages, as there is no man page command available on the target devices, and to keep the packages as small as possible.

The PLIST files contain the build artifacts that are installed and added to the spk file. Please remove any documentation, header-files, *.la, .a files and pkgconfig files (.pc). You can even omit the executable files from PLIST when a package is used as library only (maybe cross/cups ?).

BUILD_DEPENDS is used for dependencies that are required to build a package, i.e. for build tools (native/...) or for dependencies that are required to build and are prerequisites defined as SPK_DEPENDS (e.g. BUILD_DEPENDS=cross/python3 and SPK_DEPENDS = python3).
So BUILD_DEPENDS = cross/zlib should be DEPENDS = cross/zlib and many others.

We prefer official source packages when available. So avoid the download methods git and hg where ever possible.

For the jdk download it would be great when the source packages of https://github.com/openjdk/jdk/releases could be used. The hg checkout does not only have different content with each download, but it needs a long time too. And I am afraid that the max path length is reached for some source files in the temp. download location when creating the archive.

I propose to remove the ADDITIONAL_CFLAGS = -D_LINUX_QUOTA_VERSION=1 and drop DSM-5 support (as DSM-5 is EOL)

more later....

arnebjarne · 2021-08-16T09:50:59Z

some overall suggestions:
it is not worth to generate and include documentation (man pages, pdf, html, ps, ...) in the packages, as there is no man page command available on the target devices, and to keep the packages as small as possible.

Got it. I will remove them from the spk/java-11-openjdk

The PLIST files contain the build artifacts that are installed and added to the spk file. Please remove any documentation, header-files, *.la, .a files and pkgconfig files (.pc). You can even omit the executable files from PLIST when a package is used as library only (maybe cross/cups ?).

*.la and *.a I agree. headers and *.pc are needed by ./configure scripts (sort of... if packages were build in chroots then paths from *.pc would be valid ;)). I will keep *.pc's and hope that the build system get converted to chroot some day ;)

BUILD_DEPENDS is used for dependencies that are required to build a package, i.e. for build tools (native/...) or for dependencies that are required to build and are prerequisites defined as SPK_DEPENDS (e.g. BUILD_DEPENDS=cross/python3 and SPK_DEPENDS = python3).
So BUILD_DEPENDS = cross/zlib should be DEPENDS = cross/zlib and many others.

So... I did it right? java needs zlib to build, so that will be a BUILD_DEPENDS.
I have not "lint'ed" all the files in the spk to see if they have dynamic dependencies or ie. zlib have been compiled statically into Java. Does the current build system have such hook - to check for external dependencies?

We prefer official source packages when available. So avoid the download methods git and hg where ever possible.
Ok will try to avoid CVS systems.

I propose to remove the ADDITIONAL_CFLAGS = -D_LINUX_QUOTA_VERSION=1 and drop DSM-5 support (as DSM-5 is EOL)

Check, as a newbee I just followed the build example that says use ./cross/transmission as template. Maybe it should be also removed there ? ;)

BR,
Bjarne

…kage dependencies

hgy59 · 2021-08-16T16:21:11Z

*.la and *.a I agree. headers and *.pc are needed by ./configure scripts (sort of... if packages were build in chroots then paths from *.pc would be valid ;)). I will keep *.pc's and hope that the build system get converted to chroot some day ;)

The PLIST file is used to create the final spk file only. All files (whether in PLIST or not) will be available in the install folder for the build (for configure, make, make install, ...) of dependent packages.
Another hint for the creation of PLIST files:
Only real binaries are allowed to be marked as bin or lib as those will be stripped (and will log an error if strip fails). All other must be rsc (or lnk for symlinks).

sorry, I don't understand what you want to say with chroot build system...

hgy59 · 2021-08-16T16:24:32Z

So... I did it right? java needs zlib to build, so that will be a BUILD_DEPENDS.

No, I meant executables needed for build (not libraries). I successfully built for x64-6.1 and the only build dependency was jdk itself (installed with sudo apt-get install default-jdk) as it is a kind o bootstrapping here (you need jdk to build jdk).

hgy59 · 2021-08-16T16:41:43Z

Another PLIST issue:
The file spk/java-11-openjdk/PLIST must be empty, as spk/java-11-openjdk/Makefile does not build any code but uses cross/{package} dependencies that bring there own PLIST.

arnebjarne · 2021-08-16T16:53:55Z

The file spk/java-11-openjdk/PLIST must be empty, as spk/java-11-openjdk/Makefile does not build any code but uses cross/{package} dependencies that bring there own PLIST.

Ah, that I have missed. I will empty it now

arnebjarne · 2021-08-16T16:57:12Z

Still.

2021-08-16T15:08:29.1115094Z ===> Compiling for libXt
2021-08-16T15:08:29.1146371Z make[3]: Entering directory '/github/workspace/spk/java-11-openjdk/work-armv7-7.0/libXt-1.1.5'
2021-08-16T15:08:29.1176930Z make all-recursive
2021-08-16T15:08:29.1205553Z make[4]: Entering directory '/github/workspace/spk/java-11-openjdk/work-armv7-7.0/libXt-1.1.5'
2021-08-16T15:08:29.1247527Z Making all in util
2021-08-16T15:08:29.1272943Z make[5]: Entering directory '/github/workspace/spk/java-11-openjdk/work-armv7-7.0/libXt-1.1.5/util'
2021-08-16T15:08:29.1290077Z CC makestrs.o
2021-08-16T15:08:29.1371420Z In file included from /github/workspace/toolchain/syno-armv7-7.0/work/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sysroot/usr/include/features.h:447,
2021-08-16T15:08:29.1373466Z from /github/workspace/toolchain/syno-armv7-7.0/work/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sysroot/usr/include/bits/libc-header-start.h:33,
2021-08-16T15:08:29.1375585Z from /github/workspace/toolchain/syno-armv7-7.0/work/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sysroot/usr/include/stdio.h:27,
2021-08-16T15:08:29.1376612Z from makestrs.c:29:
2021-08-16T15:08:29.1378083Z /github/workspace/toolchain/syno-armv7-7.0/work/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sysroot/usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-soft.h: No such file or directory
2021-08-16T15:08:29.1382235Z # include <gnu/stubs-soft.h>
2021-08-16T15:08:29.1382636Z ^~~~~~~~~~~~~~~~~~

libXt will not compile due to an toolchain error i think.

arnebjarne · 2021-08-16T17:05:15Z

I use a rather old group of packages (from CentOS 7).
I can try rebuilding it all towards latest Fedora 34 which has latest libXt.

hgy59 · 2021-08-16T18:29:14Z

linux-gnueabi/sysroot/usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-soft.h: No such file or directory
2021-08-16T15:08:29.1382235Z # include <gnu/stubs-soft.h>
2021-08-16T15:08:29.1382636Z ^~~~~~~~~~~~~~~~~~

libXt will not compile due to an toolchain error i think.

you can fix this by adding the following lines to /spksrc/toolchain/syno-armv7-6.1/Makefile (before include ../../mk/spksrc.tc.mk)

# ensure gnu/hard-float.h is used
TC_EXTRA_CFLAGS = -D__ARM_PCS_VFP=1

arnebjarne · 2021-08-22T19:45:30Z

Now i looks very good to me
@arnebjarne can you please do the final PLIST update (and propably switch back to make product-images) as you have a real test case.

Ok ill will verify the lib list and check with make product-images

arnebjarne · 2021-08-22T20:25:03Z

@hgy59 my OCD goes off reading

OpenJDK 11 version 11.0.12+7 :-D

May I suggest

OpenJDK version 11.0.12+7 ?

in description

arnebjarne · 2021-08-22T20:29:21Z

hmm still breaks with same error though zlib is now included.

I will try compiling java with zlib=system

spk/java-11-openjdk/Makefile

…dled

cross/java-11-openjdk/Makefile

Co-authored-by: hgy59 <hpgy59@gmail.com>

cross/java-11-openjdk/Makefile

…ksrc/wiki/Makefile-variables needs update

publicarray

Small nits that I found while going over the PR. But looks good to me!

cross/java-11-openjdk/patches/002.rh1648644-java_access_bridge_privileged_security.patch

...a-11-openjdk/patches/006.rh1648249-add_commented_out_nss_cfg_provider_to_java_security.patch

cross/x11proto/Makefile

cross/xau/Makefile

cross/xcb/Makefile

cross/java-11-openjdk/Makefile

arnebjarne · 2021-08-24T17:06:06Z

I have renamed the dependencies and deleted the 2 unneedded patches.

mk/spksrc.cross-env.mk

publicarray

Great Work!

publicarray · 2021-08-26T00:49:46Z

If you have PARALLEL_MAKE = max in your local.mk the build fails:

$ make -C spk/java-11-openjdk arch-x64-7.0
[..]
===>  Compiling for java-11-openjdk
sed -i -e "s|\$(INSTALL_PREFIX)|/spksrc/spk/java-11-openjdk/work-x64-7.0/install/var/packages/java-11-openjdk/target|g" /spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7/make/Install.gmk
make[3]: Entering directory '/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7'
Note: Command line contains non-control variables:
* TCVERSION=7.0
* ARCH=x64
Make sure it is not mistyped, and that you intend to override this variable.
'make help' will list known control variables.

make[4]: Entering directory '/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7'
make[4]: Leaving directory '/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7'
Error: 'make -jN' is not supported, use 'make JOBS=N'
/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7/make/Init.gmk:115: *** Cannot continue.  Stop.

arnebjarne · 2021-08-26T09:37:08Z

If you have PARALLEL_MAKE = max in your local.mk the build fails:

$ make -C spk/java-11-openjdk arch-x64-7.0
[..]
===>  Compiling for java-11-openjdk
sed -i -e "s|\$(INSTALL_PREFIX)|/spksrc/spk/java-11-openjdk/work-x64-7.0/install/var/packages/java-11-openjdk/target|g" /spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7/make/Install.gmk
make[3]: Entering directory '/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7'
Note: Command line contains non-control variables:
* TCVERSION=7.0
* ARCH=x64
Make sure it is not mistyped, and that you intend to override this variable.
'make help' will list known control variables.

make[4]: Entering directory '/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7'
make[4]: Leaving directory '/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7'
Error: 'make -jN' is not supported, use 'make JOBS=N'
/spksrc/spk/java-11-openjdk/work-x64-7.0/jdk11u-jdk-11.0.12-7/make/Init.gmk:115: *** Cannot continue.  Stop.

Ok I will change the Makefile. I have seen some races in cups I think, but since I have reduced cups to only build the libcups.so it might be unneeded.

publicarray · 2021-08-26T23:04:26Z

Thanks for your work on this.
So annoying that this is a hard error not just a soft fail.

* Initial java-1.8.0-openjdk package * Added LICENSE files * Disabled parallel build for cups due to race conditions * Removed Java AOT. Not available on all arches * Removed debug symbols and cups to reduce package size * Changed zlib,libjpeg,giflib,libpng and lcms to use system and not bundled * Removed RedHat patches and added Debian patches * Added fix for PARALLEL_MAKE Co-authored-by: hgy59 <hpgy59@gmail.com>

DigitalBox98 · 2021-08-30T15:14:13Z

Really nice work for the missing java on DSM 7.0 :)

Added missing digests for java-11-openjdk packages

e9dfe9f

arnebjarne mentioned this pull request Aug 15, 2021

[Package Request] OpenJDK #4773

Closed

arnebjarne added 2 commits August 15, 2021 17:23

Initial java-1.8.0-openjdk package

225a046

Sigh... another digests missing

bbe9dae

publicarray reviewed Aug 15, 2021

View reviewed changes

spk/java-11-openjdk/Makefile Outdated Show resolved Hide resolved

arnebjarne added 5 commits August 15, 2021 18:59

Added LICENSE files

2664417

Added missing digests

f33f216

Merge branch 'java11-openjdk-missing-digests' of github.com:arnebjarn…

b01ae35

…e/spksrc into openjdk-with-missing-digests

Added java-11-openjdk/src/LICENSE

7b3d9f8

Added zip as dependency for java-11-openjdk

fd22317

Made a type in archive name. fixed

a138460

arnebjarne added 3 commits August 16, 2021 15:08

Added zip path to java-11-openjdk. Removed man and doc pages from pac…

3ab3d70

…kage dependencies

Added Java 7 binaries for bootstrapping

ed09779

Replaced bootstap Java with version 11

aae14a6

Zero'ed spk/java-11-openjdk/PLIST

3e6a8a1

arnebjarne added 5 commits August 16, 2021 22:38

All dependencies updated to newer versions

6fe8f60

Trying to fix a linking problem in cups

a63c189

doh. forgot to re-include cross/gnutls in cross/cups

64a2df3

more lib paths added to cross/cups

f0dd6e4

Always help with correct code...

aa4a154

hgy59 changed the title ~~Added missing digests for java-11-openjdk packages~~ Add java-11-openjdk Aug 17, 2021

Added missing zlib and libpng, also reverted to build product-images

e1aa7b7

hgy59 reviewed Aug 22, 2021

View reviewed changes

spk/java-11-openjdk/Makefile Outdated Show resolved Hide resolved

Changed zlib,libjpeg,giflib,libpng and lcms to use system and not bun…

900c8f3

…dled

hgy59 reviewed Aug 22, 2021

View reviewed changes

cross/java-11-openjdk/Makefile Outdated Show resolved Hide resolved

Update cross/java-11-openjdk/Makefile

8ba735f

Co-authored-by: hgy59 <hpgy59@gmail.com>

hgy59 reviewed Aug 22, 2021

View reviewed changes

cross/java-11-openjdk/Makefile Show resolved Hide resolved

Added support for kernel headers. https://github.com/SynoCommunity/sp…

5cbeaf9

…ksrc/wiki/Makefile-variables needs update

hgy59 requested a review from publicarray August 23, 2021 20:17

publicarray reviewed Aug 24, 2021

View reviewed changes

Renamed dependencies. Deleted 2 unneeded patches

475254f

hgy59 reviewed Aug 24, 2021

View reviewed changes

mk/spksrc.cross-env.mk Outdated Show resolved Hide resolved

arnebjarne added 3 commits August 24, 2021 19:21

Removed another PR cross over

f717669

Removed licence files from previously bundled libs

abbecda

Removed RedHat patches and added Debian patches

72fbdab

arnebjarne requested a review from publicarray August 24, 2021 23:07

publicarray approved these changes Aug 25, 2021

View reviewed changes

publicarray linked an issue Aug 26, 2021 that may be closed by this pull request

[Package Request] OpenJDK #4773

Closed

Added fix for PARALLEL_MAKE

7c32042

publicarray merged commit 6f9a00f into SynoCommunity:master Aug 26, 2021

mreid-tt mentioned this pull request Feb 14, 2023

[Package Request] Java 17 OpenJDK - New LTS Version of Java #5605

Closed

hgy59 mentioned this pull request Dec 24, 2024

OpenJDK 21 compilation issue #6359

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add java-11-openjdk #4784

Add java-11-openjdk #4784

arnebjarne commented Aug 15, 2021 •

edited by hgy59

Loading

hgy59 commented Aug 15, 2021

arnebjarne commented Aug 16, 2021

hgy59 commented Aug 16, 2021

hgy59 commented Aug 16, 2021

hgy59 commented Aug 16, 2021

arnebjarne commented Aug 16, 2021

arnebjarne commented Aug 16, 2021

arnebjarne commented Aug 16, 2021

hgy59 commented Aug 16, 2021

arnebjarne commented Aug 22, 2021

arnebjarne commented Aug 22, 2021

arnebjarne commented Aug 22, 2021

publicarray left a comment

arnebjarne commented Aug 24, 2021

publicarray left a comment

publicarray commented Aug 26, 2021 •

edited

Loading

arnebjarne commented Aug 26, 2021

publicarray commented Aug 26, 2021

DigitalBox98 commented Aug 30, 2021

Add java-11-openjdk #4784

Add java-11-openjdk #4784

Conversation

arnebjarne commented Aug 15, 2021 • edited by hgy59 Loading

Checklist

hgy59 commented Aug 15, 2021

arnebjarne commented Aug 16, 2021

hgy59 commented Aug 16, 2021

hgy59 commented Aug 16, 2021

hgy59 commented Aug 16, 2021

arnebjarne commented Aug 16, 2021

arnebjarne commented Aug 16, 2021

arnebjarne commented Aug 16, 2021

hgy59 commented Aug 16, 2021

arnebjarne commented Aug 22, 2021

arnebjarne commented Aug 22, 2021

arnebjarne commented Aug 22, 2021

publicarray left a comment

Choose a reason for hiding this comment

arnebjarne commented Aug 24, 2021

publicarray left a comment

Choose a reason for hiding this comment

publicarray commented Aug 26, 2021 • edited Loading

arnebjarne commented Aug 26, 2021

publicarray commented Aug 26, 2021

DigitalBox98 commented Aug 30, 2021

arnebjarne commented Aug 15, 2021 •

edited by hgy59

Loading

publicarray commented Aug 26, 2021 •

edited

Loading