Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update fish to 3.3.1 #4815

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Conversation

etcusrvar
Copy link
Contributor

Motivation: Update fish to 3.3.1

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

The evansport can't find pthreads.h error is actually a broken gold linker
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really "gold" linker or just "old" linker?

@publicarray
Copy link
Member

@hgy59 I know yes really 🤣, I've not heard about it before until my earlier encounter with the same issue here: #4494 (comment)

If you need proof: See the patch file:

if ("${LD_VERSION}" MATCHES "GNU gold")

set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=gold")

https://en.wikipedia.org/wiki/Gold_(linker)

@etcusrvar
Copy link
Contributor Author

etcusrvar commented Aug 28, 2021

Since we're removing the gold linker stuff from a patch named ...remove-gold-linker..., wouldn't it make sense to remove the patch file entirely?
Are the add_compile_options... and source_group... lines really needed?
The patch file was added in #4494 that @publicarray mentioned.

@publicarray
Copy link
Member

No, The patch removes the lines from the cmake file in the fish source code. The lines begin with -. If they where + then we would add lines.

@publicarray
Copy link
Member

Those two lines give context about where in the source the patch should be applied. The file was auto generated.

@publicarray publicarray merged commit ec8c816 into SynoCommunity:master Aug 29, 2021
@etcusrvar etcusrvar deleted the fish-3.3.1 branch August 30, 2021 16:27
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
* feat: Update fish to 3.3.1

* Add fish license file and fix evansport build

The evansport can't find pthreads.h error is actually a broken gold linker

Co-authored-by: Sebastian Schmidt <publicarray@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants