Comply to DSM7 and set as broken #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
th0ma7
changed the title
publicarray
reviewed
Oct 14, 2021
publicarray
reviewed
Oct 14, 2021
|
Friendly reminder, if anyone could have a second look at this for a review. Thnx in advance. |
ymartin59
approved these changes
Nov 20, 2021
th0ma7
force-pushed
the
broken_DSM7comply
branch
from
eed705f to
4d3010c
Compare
publicarray
pushed a commit
to publicarray/spksrc
that referenced
this pull request
Dec 19, 2021
* pre-check.mk: Force complying to service-setup for DSM >= 7 * pre-check.mk: Add option to declare broken packages * pre-check.mk: Fix typo (thnx @publicarray)
AlexPresso
pushed a commit
to AlexPresso/spksrc
that referenced
this pull request
Jan 30, 2025
* pre-check.mk: Force complying to service-setup for DSM >= 7 * pre-check.mk: Add option to declare broken packages * pre-check.mk: Fix typo (thnx @publicarray)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Extracting trivial build fixes from #4797 to keep only things in scope of that rather large PR. This patchset enforce package to compliance to DSM7 and allow marking packages as BROKEN.
src/installer.sh) dates from pre-DSM6 and should be marked as incompatible with DSM7 to avoid building it and provide clean github-action outputs. This is done by checking if the package is making use of theINSTALLER_SCRIPTsuch asINSTALLER_SCRIPT = src/installer.sh. This necessarily means that it hasn't been migrated to DSM6+ default framework method usingSERVICE_SETUP = src/service-setup.sh. As such there is not value at trying to build them for DSM7 and are being excluded from the build process, thus reducing time to build and removing false-positive.BROKENfile in its directory. File can be empty or include reasons why it is currently being marked as such for future work in fixing it occurs. Simply add aspk/<app>/BROKENfile with what ever comments to explain reasons for it. Starting with the following packages:debian-chrootgentoo-chrootpyloadsickchillLinked issues: Build output example with this patchset applied can be looked at #4797
Checklist
all-supportedcompleted successfully