Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native/yasm: use github release & cross/libsodium: update digests #4963

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

publicarray
Copy link
Member

See: #4951 (comment)

Just in-case the cert expires again

Checklist

  • native build

@th0ma7
Copy link
Contributor

th0ma7 commented Nov 11, 2021

Why is it failing? This seems like a trivial PR...

EDIT: That's interesting:

===>  Verifying files for libsodium
===>    Checking sha1sum of file libsodium-1.0.18-stable.tar.gz
===>      Wrong sha1sum for file libsodium-1.0.18-stable.tar.gz
===>      Renamed as libsodium-1.0.18-stable.tar.gz.wrong
===>      Download cookie removed to trigger the download again

So it ends-up that a make digests does solve the issue. Tested and updated as of today. Too bad they keep re-updating this stable version instead of publishing a x.19...

@th0ma7 th0ma7 changed the title native/yasm: use github release native/yasm: use github release & cross/libsodium: update digests Nov 11, 2021
@th0ma7
Copy link
Contributor

th0ma7 commented Nov 11, 2021

@publicarray I suggest we simply merge this and start using github by default. Are you ok with this?

@publicarray
Copy link
Member Author

I used minisign to verify the signature of libsodium 👍

@publicarray publicarray merged commit 707f36b into SynoCommunity:master Nov 11, 2021
@publicarray
Copy link
Member Author

@th0ma7 Thank you!

@publicarray publicarray deleted the yasm-cert branch November 11, 2021 22:05
@publicarray
Copy link
Member Author

Arch uses libsodium-1.0.18.tar.gz not libsodium-1.0.18-stable.tar.gz. maybe that is part of the problem we are using the wrong file?. https://github.com/archlinux/svntogit-packages/blob/packages/libsodium/trunk/PKGBUILD

@th0ma7
Copy link
Contributor

th0ma7 commented Nov 11, 2021

I've switched to -stable a few weeks ago due to build issues elsewhere in the python dreamworld :)

@publicarray
Copy link
Member Author

@publicarray
Copy link
Member Author

publicarray commented Nov 11, 2021

Based on he's response I think we should be using libsodium-1.0.18.tar.gz

This was referenced Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants