Migrate remaining python3 packages to python310 #4998

th0ma7 · 2021-12-13T01:06:59Z

Motivation: Migrate remaining python3 (3.7.x) and python38 packages to python310.
Linked issues: Follow-up to #4986

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

To migrate

bazarr - on top of bazarr: 1.0.1 #4992 - Tested: kvmx64-7.0, armv7-7.0, armv5tel-6.1
fishnet - Tested: kvmx64-7.0, armv7-7.0
plexpy-custom - Tested: kvmx64-7.0, armv7-7.0, armv5tel-6.1
rutorrent *** ~~requires migrating to DSM7~~ update to DSM7 for a later PR *** - Tested: x64-6.1
salt-minion - update on-going Salt 3003.3 update #4845 - Moved to PR Update salt-minion to 3004 and python310 #5017

publicarray · 2021-12-13T11:02:13Z

Just a kind reminder to Please check open PRs e.g salt has a major one that I think is good to merge. And bazar

th0ma7 · 2021-12-13T12:38:07Z

Just a kind reminder to Please check open PRs e.g salt has a major one that I think is good to merge. And bazar

Thnx, good points. I wasn't able to find bazar anywhere though.

smaarn · 2021-12-13T15:44:19Z

Just a kind reminder to Please check open PRs e.g salt has a major one that I think is good to merge. And bazar

Thnx, good points. I wasn't able to find bazar anywhere though.

Bazarr just made it to the master a couple of weeks ago.
There is one concern though: it has not been tested on Python 3.10 according to the developer's page. You may be facing unexpected issues.

publicarray · 2021-12-13T19:53:07Z

Thanks for the info. I mean this version bump #4992

th0ma7 · 2021-12-13T22:05:27Z

Bazarr just made it to the master a couple of weeks ago. There is one concern though: it has not been tested on Python 3.10 according to the developer's page. You may be facing unexpected issues.

@smaarn thnx for the info. I noticed the bazarr 1.0.1 pending PR (thnx to @publicarray). Similar to salt, once merged I could dive into it to prepare the migration towards python310 for you to test? I also noticed the soon to be released 1.0.2 (currently at beta6), perhaps this solves compatibility issues with python310?

smaarn · 2021-12-14T05:44:41Z

Bazarr just made it to the master a couple of weeks ago. There is one concern though: it has not been tested on Python 3.10 according to the developer's page. You may be facing unexpected issues.

@smaarn thnx for the info. I noticed the bazarr 1.0.1 pending PR (thnx to @publicarray). Similar to salt, once merged I could dive into it to prepare the migration towards python310 for you to test? I also noticed the soon to be released 1.0.2 (currently at beta6), perhaps this solves compatibility issues with python310?

@th0ma7 I will be checking if it does fix any compatibility issue explicitely but either way I remain at your disposal to test upgrade.

smaarn · 2021-12-18T10:38:09Z

Bazarr just made it to the master a couple of weeks ago. There is one concern though: it has not been tested on Python 3.10 according to the developer's page. You may be facing unexpected issues.

@smaarn thnx for the info. I noticed the bazarr 1.0.1 pending PR (thnx to @publicarray). Similar to salt, once merged I could dive into it to prepare the migration towards python310 for you to test? I also noticed the soon to be released 1.0.2 (currently at beta6), perhaps this solves compatibility issues with python310?

@th0ma7 I will be checking if it does fix any compatibility issue explicitely but either way I remain at your disposal to test upgrade.

@th0ma7 sorry for the delays. Just checked the changelogs for the ongoing 1.0.2 beta and it seems that the job has been started but it's not supported "as of now". I remain at your disposal to test any beta version you wish to propose (or I can start the migration in its own stream if you prefer).

th0ma7 · 2021-12-19T20:42:19Z

@smaarn I had a few cycles to play with it today and was able using latest 1.0.2-beta9 to get it working with python310. Mind having a try? I can provide packages as needed.

th0ma7 · 2021-12-23T02:22:06Z

@smaarn friendly reminder, now updated using latest beta10 for you to test out. Again thnx in advance and happy holiday season!

smaarn · 2021-12-24T09:45:20Z

@smaarn friendly reminder, now updated using latest beta10 for you to test out. Again thnx in advance and happy holiday season!

I will be having a look. Do you mind going for the 1.0.2-beta-11 version instead (I'm doing it locally already and can commit but don't want to interfere with your work) ?(https://github.com/morpheus65535/bazarr/releases/tag/v1.0.2-beta.11 => I actually use Addic7ed :D )

th0ma7 · 2021-12-24T12:19:32Z

@smaarn I was actually hoping a final release would happen before I merge. In the meantime beta11 commit done!

And? is it working all right?

smaarn · 2021-12-24T12:32:08Z

@smaarn I was actually hoping a final release would happen before I merge. In the meantime beta11 commit done!

And? is it working all right?

@th0ma7 totally in line with the only releasing when 1.0.2 official release is there. Actually I am still trying to build on my (very old) mac so I'll be taking whichever comes first between github and my local :D Should be able to tell you if there's anything wrong by EOD.

smaarn · 2021-12-24T14:20:30Z

@smaarn I was actually hoping a final release would happen before I merge. In the meantime beta11 commit done!

And? is it working all right?

There seems to be an issue on my end with numpy which fails loading upon start. Checking.

Fri Dec 24 15:17:58 CET 2021
Starting bazarr command env LANG=en_US.UTF-8 LC_ALL=en_US.utf8 /volume1/@appstore/bazarr/env/bin/python3 /volume1/@appstore/bazarr/share/bazarr/bazarr.py --no-update --config /volume1/@appdata/bazarr/data  
Traceback (most recent call last):
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/main.py", line 31, in <module>
    from get_series import *
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_series.py", line 12, in <module>
    from get_episodes import sync_episodes
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_episodes.py", line 12, in <module>
    from get_subtitle import episode_download_subtitles
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_subtitle.py", line 35, in <module>
    from subsyncer import subsync
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/subsyncer.py", line 3, in <module>
    from ffsubsync.ffsubsync import run, make_parser
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/../libs/ffsubsync/__init__.py", line 21, in <module>
    from .ffsubsync import main  # noqa
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/../libs/ffsubsync/ffsubsync.py", line 11, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'
Python version greater than 3.8.x is unsupported. Current version is 3.10.0. Keep in mind that even if it works, you're on your own.
Bazarr starting...
Bazarr exited.

smaarn · 2021-12-24T14:24:51Z

@smaarn I was actually hoping a final release would happen before I merge. In the meantime beta11 commit done!
And? is it working all right?

There seems to be an issue on my end with numpy which fails loading upon start. Checking.

Fri Dec 24 15:17:58 CET 2021
Starting bazarr command env LANG=en_US.UTF-8 LC_ALL=en_US.utf8 /volume1/@appstore/bazarr/env/bin/python3 /volume1/@appstore/bazarr/share/bazarr/bazarr.py --no-update --config /volume1/@appdata/bazarr/data  
Traceback (most recent call last):
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/main.py", line 31, in <module>
    from get_series import *
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_series.py", line 12, in <module>
    from get_episodes import sync_episodes
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_episodes.py", line 12, in <module>
    from get_subtitle import episode_download_subtitles
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_subtitle.py", line 35, in <module>
    from subsyncer import subsync
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/subsyncer.py", line 3, in <module>
    from ffsubsync.ffsubsync import run, make_parser
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/../libs/ffsubsync/__init__.py", line 21, in <module>
    from .ffsubsync import main  # noqa
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/../libs/ffsubsync/ffsubsync.py", line 11, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'
Python version greater than 3.8.x is unsupported. Current version is 3.10.0. Keep in mind that even if it works, you're on your own.
Bazarr starting...
Bazarr exited.

https://github.com/numpy/numpy/releases/tag/v1.21.5 => We may need to upgrade numpy. Checking for more details.

smaarn · 2021-12-24T14:28:16Z

@smaarn I was actually hoping a final release would happen before I merge. In the meantime beta11 commit done!
And? is it working all right?

There seems to be an issue on my end with numpy which fails loading upon start. Checking.

Fri Dec 24 15:17:58 CET 2021
Starting bazarr command env LANG=en_US.UTF-8 LC_ALL=en_US.utf8 /volume1/@appstore/bazarr/env/bin/python3 /volume1/@appstore/bazarr/share/bazarr/bazarr.py --no-update --config /volume1/@appdata/bazarr/data  
Traceback (most recent call last):
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/main.py", line 31, in <module>
    from get_series import *
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_series.py", line 12, in <module>
    from get_episodes import sync_episodes
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_episodes.py", line 12, in <module>
    from get_subtitle import episode_download_subtitles
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/get_subtitle.py", line 35, in <module>
    from subsyncer import subsync
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/subsyncer.py", line 3, in <module>
    from ffsubsync.ffsubsync import run, make_parser
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/../libs/ffsubsync/__init__.py", line 21, in <module>
    from .ffsubsync import main  # noqa
  File "/volume1/@appstore/bazarr/share/bazarr/bazarr/../libs/ffsubsync/ffsubsync.py", line 11, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'
Python version greater than 3.8.x is unsupported. Current version is 3.10.0. Keep in mind that even if it works, you're on your own.
Bazarr starting...
Bazarr exited.

https://github.com/numpy/numpy/releases/tag/v1.21.5 => We may need to upgrade numpy. Checking for more details.

... We enter uncharted territories...

===>  Compiling for numpy
setup.py:63: RuntimeWarning: NumPy 1.21.5 may not yet support Python 3.10.
  warnings.warn(

spk/bazarr/src/service-setup.sh

smaarn · 2021-12-24T15:11:00Z

It seems that the current outcome for bazarr package doesn't actually work as it tries to build native wheels when installing. There must be something odd with the way the wheels are being shipped here. As it doesn't seem to "see" them.

smaarn · 2021-12-24T15:28:57Z

It seems that the current outcome for bazarr package doesn't actually work as it tries to build native wheels when installing. There must be something odd with the way the wheels are being shipped here. As it doesn't seem to "see" them.

@th0ma7 to conclude (keeping in mind that I'm installing on an x64 Synology DSM 7 NAS):

Python 3.10 seems to be OK (by tweaking the build and the installation process for the wheels it seemed to work)
We may need to upgrade numpy but could be challenged
The way wheels are being installed seem to no longer be working

Would need a little bit more time to investigate upon 3rd point. If there is no urgency I should be able to do that next week.

th0ma7 · 2021-12-24T16:44:43Z

It seems that the current outcome for bazarr package doesn't actually work as it tries to build native wheels when installing. There must be something odd with the way the wheels are being shipped here. As it doesn't seem to "see" them.

It's the expected outcome: pure python wheel are downloaded online (and built locally when unavailable). Only cross-compiled wheels are now provided. That being said, we can workaround that and enforce building + packaging of pure-python wheels as well.

When I tested it on kvmx64 install was all good. I'll have to double-check and I'll check as well on armv7 and armv5 to confirm the actual behavior.

th0ma7 · 2022-01-02T19:48:21Z

@smaarn rebased against master which now includes your latest changes. Hopefully issues are now all solved. Let me know how things turn out while re-testing bazarr. Thnx!

spk/fishnet/Makefile

smaarn · 2022-01-02T21:03:56Z

@smaarn rebased against master which now includes your latest changes. Hopefully issues are now all solved. Let me know how things turn out while re-testing bazarr. Thnx!

I can confirm it works like a charm !

smaarn

Talking about the bazarr side, as far as I'm concerned, it seems to be working fine.

Co-authored-by: hgy59 <hpgy59@gmail.com>

th0ma7 · 2022-01-02T21:20:30Z

Talking about the bazarr side, as far as I'm concerned, it seems to be working fine.

Perfect, and thnx for your help, much appreciated!

publicarray · 2022-01-02T21:25:08Z

Besides, beets have any of them been published? I'm also referring to: #4986 the label says status/published but I don't think I can find them

publicarray · 2022-01-02T21:34:57Z

Good work on getting everything upgraded to python 3.10! 🎉

th0ma7 self-assigned this Dec 13, 2021

hgy59 mentioned this pull request Dec 13, 2021

Deactivate python2 #4303

Closed

10 tasks

th0ma7 force-pushed the python38-others branch 2 times, most recently from 2000421 to b9f5a63 Compare December 19, 2021 22:07

th0ma7 mentioned this pull request Dec 19, 2021

WEBRTC_ARCH_*, PPC and environment variable? wiseman/py-webrtcvad#78

Open

th0ma7 force-pushed the python38-others branch from 47c5eca to 9d838e9 Compare December 20, 2021 02:39

th0ma7 requested review from hgy59 and publicarray December 20, 2021 02:39

th0ma7 changed the title ~~[WIP] Migrate remaining python3 packages to python310~~ Migrate remaining python3 packages to python310 Dec 20, 2021

th0ma7 added the status/needs-review label Dec 20, 2021

th0ma7 mentioned this pull request Dec 23, 2021

Add support for 'setup.py' nor 'pyproject.toml' morpheus65535/bazarr#1648

Closed

smaarn reviewed Dec 24, 2021

View reviewed changes

spk/bazarr/src/service-setup.sh Show resolved Hide resolved

th0ma7 added 16 commits January 2, 2022 19:46

rutorrent: Migrate to python310

3b0858a

bazarr: Update to beta10 pending finale 1.0.2 release

05b5168

bazarr: Fix webrtc using unreleased version of wheel from github

ca69c18

bazarr: Add comments related to using github as source

890e0fd

bazarr: Update to latest beta 11

40aeda5

blasfeo: Add blas library for numpy optimization and building

9d4c1c8

bazarr: Add python310 compatible numpy version

a7625d0

bazarr: Declare armv5 as unsupported due to numpy

f47e8da

bazarr: Update to version beta12

ad2b97b

blasfeo: Remove as unecessary

64a78de

bazarr: Use new python framework functionality for numpy

e88c620

bazarr: Update to v1.0.2 finale & update digests

fc4256e

bazarr: Adjust comment and change info

1fb3f00

python310+bazarr: Migrate numpy to 1.22.0

013614d

bazarr: Fixing typo

e73f644

wheel-env.mk: bazarr+python310: Fix git+https type URL-based req

abcd69a

th0ma7 force-pushed the python38-others branch from 6ee9062 to abcd69a Compare January 2, 2022 19:46

bazarr: Move placement of compile FLAGS for numpy (@smaarn)

914fe56

th0ma7 added status/ready-to-merge and removed status/needs-review labels Jan 2, 2022

hgy59 reviewed Jan 2, 2022

View reviewed changes

spk/fishnet/Makefile Outdated Show resolved Hide resolved

smaarn approved these changes Jan 2, 2022

View reviewed changes

Update spk/fishnet/Makefile

7658a7d

Co-authored-by: hgy59 <hpgy59@gmail.com>

th0ma7 merged commit 95fe355 into SynoCommunity:master Jan 2, 2022

th0ma7 deleted the python38-others branch January 2, 2022 21:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate remaining python3 packages to python310 #4998

Migrate remaining python3 packages to python310 #4998

th0ma7 commented Dec 13, 2021 •

edited

Loading

publicarray commented Dec 13, 2021 •

edited

Loading

th0ma7 commented Dec 13, 2021

smaarn commented Dec 13, 2021 •

edited

Loading

publicarray commented Dec 13, 2021

th0ma7 commented Dec 13, 2021

smaarn commented Dec 14, 2021

smaarn commented Dec 18, 2021

th0ma7 commented Dec 19, 2021

th0ma7 commented Dec 23, 2021

smaarn commented Dec 24, 2021 •

edited

Loading

th0ma7 commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

th0ma7 commented Dec 24, 2021

th0ma7 commented Jan 2, 2022

smaarn commented Jan 2, 2022

smaarn left a comment

th0ma7 commented Jan 2, 2022

publicarray commented Jan 2, 2022 •

edited

Loading

publicarray commented Jan 2, 2022

Migrate remaining python3 packages to python310 #4998

Migrate remaining python3 packages to python310 #4998

Conversation

th0ma7 commented Dec 13, 2021 • edited Loading

Checklist

To migrate

publicarray commented Dec 13, 2021 • edited Loading

th0ma7 commented Dec 13, 2021

smaarn commented Dec 13, 2021 • edited Loading

publicarray commented Dec 13, 2021

th0ma7 commented Dec 13, 2021

smaarn commented Dec 14, 2021

smaarn commented Dec 18, 2021

th0ma7 commented Dec 19, 2021

th0ma7 commented Dec 23, 2021

smaarn commented Dec 24, 2021 • edited Loading

th0ma7 commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

smaarn commented Dec 24, 2021

th0ma7 commented Dec 24, 2021

th0ma7 commented Jan 2, 2022

smaarn commented Jan 2, 2022

smaarn left a comment

Choose a reason for hiding this comment

th0ma7 commented Jan 2, 2022

publicarray commented Jan 2, 2022 • edited Loading

publicarray commented Jan 2, 2022

th0ma7 commented Dec 13, 2021 •

edited

Loading

publicarray commented Dec 13, 2021 •

edited

Loading

smaarn commented Dec 13, 2021 •

edited

Loading

smaarn commented Dec 24, 2021 •

edited

Loading

publicarray commented Jan 2, 2022 •

edited

Loading