Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readline #5075

Merged
merged 1 commit into from
Jan 14, 2022
Merged

fix readline #5075

merged 1 commit into from
Jan 14, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Jan 13, 2022

Description

current version of cross/readline fails to build.

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Build fix
  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

- disable static libraries to avoid build error
- disable tests to avoid build error
- activate code optimization
@hgy59
Copy link
Contributor Author

hgy59 commented Jan 13, 2022

this one seems to be a pre-requisite for #5047

@hgy59
Copy link
Contributor Author

hgy59 commented Jan 13, 2022

without this fix I get errors when building cross/readline:

( cd examples ; make -w DESTDIR=/spksrc/cross/readline/work-x64-6.1/install install )
make[4]: Entering directory '/spksrc/cross/readline/work-x64-6.1/readline-8.1/examples'
/bin/sh ../support/mkdirs /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/share/readline
mkdir /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/share/readline
/usr/bin/install: cannot stat './rltest2.c': No such file or directory
make[4]: Leaving directory '/spksrc/cross/readline/work-x64-6.1/readline-8.1/examples'
/usr/bin/install -c -m 644 /spksrc/cross/readline/work-x64-6.1/readline-8.1/readline.pc /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/pkgconfig/readline.pc
mv /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libreadline.a /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libreadline.old
mv: cannot stat '/spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libreadline.a': No such file or directory
make[3]: [Makefile:254: install-static] Error 1 (ignored)
/usr/bin/install -c -m 644 libreadline.a /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libreadline.a
test -n "/spksrc/toolchain/syno-x64-6.1/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-ranlib" && /spksrc/toolchain/syno-x64-6.1/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-ranlib /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libreadline.a
mv /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libhistory.a /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libhistory.old
mv: cannot stat '/spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libhistory.a': No such file or directory
make[3]: [Makefile:257: install-static] Error 1 (ignored)
/usr/bin/install -c -m 644 libhistory.a /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libhistory.a
test -n "/spksrc/toolchain/syno-x64-6.1/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-ranlib" && /spksrc/toolchain/syno-x64-6.1/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-ranlib /spksrc/cross/readline/work-x64-6.1/install/usr/local/readline/lib/libhistory.a
test -d shlib || mkdir shlib
( cd shlib ; make -w all )

@th0ma7
Copy link
Contributor

th0ma7 commented Jan 14, 2022

Interesting... btw I haven't yet merged ncurses as there is an issue where pkgconfig directory does not get installed at the right location... still pending more info from upstream.

@hgy59 hgy59 merged commit 8e97406 into SynoCommunity:master Jan 14, 2022
@hgy59 hgy59 deleted the fix-readline branch May 20, 2023 10:22
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
- disable static libraries to avoid build error
- disable tests to avoid build error
- activate code optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants