-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-handling of the gcc version through TC_GCC #5099
Conversation
@hgy59 if I recall you're the one that last played with this code. I came accros this and thought that would eliminate any remaining potential false-positives. Note that I tried finding something similar for GLIBC but that ain't as easy as I thought. That may be for another time. |
I wonder if it would be "enough" to retrieve information from |
@ymartin59 its exactly that:
|
When invoking make download from spksrc/kernel/syno-* directories the resulting tc_vars.mk cannot fetch gcc's version as the toolchain hasn't been extracted yet. The following ensure it does not fail and simply produce an empty TC_GCC variable in tc_vars.mk
@hgy59 and @ymartin59 this is ready for merge. I've rebased against master and recent changes on the toolchain & kernel. This really is a relatively trivial change that removes all Before merging a quick review from on of you would be appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
was just wondering whether it would be possible to get the glibc version from the executables too.
(tried https://stackoverflow.com/questions/15134548/which-glibc-version-is-using-my-toolchain and https://stackoverflow.com/questions/9705660/check-glibc-version-for-a-particular-gcc-compiler but didn't find the matching version).
I also tried but failed miserably in doing so for GLIBC... perhaps in a subsequent PR. |
Description
While working on a build issue with
comcerto2k
on DSM7 where it uses an older gcc version than other archs (ref. #5096), I thought of removing the manually providedTC_GCC
to the benefit of automating it.Checklist
all-supported
completed successfullyType of change