Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lidarr: Update dotnet build for DSM 7.2 #5584

Merged
merged 9 commits into from
Apr 15, 2023

Conversation

mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Feb 1, 2023

Description

This includes the following fixes:

  1. Update dotnet build for DSM 7.2
  2. Update compatible ARMv7 archs
  3. Add support for x86 (32-bit) architecture
  4. Remove outdated mono builds

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • Package update

@mreid-tt mreid-tt self-assigned this Feb 1, 2023
@mreid-tt mreid-tt mentioned this pull request Feb 1, 2023
10 tasks
@mreid-tt mreid-tt changed the title [WIP] Lidarr: package udpate [WIP] Lidarr: package update Feb 1, 2023
@mreid-tt mreid-tt force-pushed the lidarr-patch branch 4 times, most recently from c20a762 to 6a65cf3 Compare February 4, 2023 02:28
@mreid-tt mreid-tt force-pushed the lidarr-patch branch 2 times, most recently from b8f4fde to a963814 Compare February 11, 2023 11:17
Update Makefile
Update service setup
@mreid-tt mreid-tt added dotnet Related to dotnet (core) dsm 7.2 labels Apr 13, 2023
@mreid-tt mreid-tt changed the title [WIP] Lidarr: package update Lidarr: Update dotnet build for DSM 7.2 Apr 13, 2023
@mreid-tt
Copy link
Contributor Author

mreid-tt commented Apr 13, 2023

@hgy59, I believe this should be the first of the *arr packages formally tested under DSM 7.2. Install and upgrade both succeeded with DSM 7.2-64216. It resolves the issue with the previous build which reported:

/var/log/packages/lidarr.log

2023/04/13 12:14:58	install lidarr 20221114-10 Begin start-stop-status start
/var/packages/lidarr/scripts/start-stop-status: line 151: 24133 Aborted                 (core dumped) ${service} >> ${OUT} 2>&1
2023/04/13 12:16:29	install lidarr 20221114-10 End start-stop-status start ret=[1]

Let me know if we are good to merge.

@mreid-tt mreid-tt merged commit 1c05e6a into SynoCommunity:master Apr 15, 2023
@mreid-tt mreid-tt deleted the lidarr-patch branch April 15, 2023 01:54
@mreid-tt
Copy link
Contributor Author

mreid-tt commented Apr 15, 2023

@publicarray, thanks for the approval.

EDIT: There was a new Lidarr released and I would prefer if that one be published (see #5698).

@mreid-tt mreid-tt removed the request for review from hgy59 April 15, 2023 01:56
@mreid-tt mreid-tt mentioned this pull request Apr 15, 2023
7 tasks
AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
* Update dotnet build for DSM 7.2
* Add exclusions for ARMv7 archs
* Add build for x86 architecture
* Remove outdated mono version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Related to dotnet (core) dsm 7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants