Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt no. 2 at fixing publishing whith dependent packages #5876

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Attempt no. 2 at fixing publishing whith dependent packages #5876

merged 1 commit into from
Sep 10, 2023

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Sep 10, 2023

Description

Attempt no. 2 at fixing publishing whith dependent packages

Fixes #5870 and relates to #5874

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 requested a review from hgy59 September 10, 2023 20:12
@th0ma7 th0ma7 self-assigned this Sep 10, 2023
@th0ma7 th0ma7 mentioned this pull request Sep 10, 2023
Closed
1 task
hgy59
hgy59 approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@hgy59 hgy59 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
since dependent packages python* and ffmpeg* are arch specific, this is enough.
well done.

@th0ma7 th0ma7 merged commit 68d9a87 into SynoCommunity:master Sep 10, 2023
1 check passed
@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 10, 2023

Let's see how it behave https://github.com/th0ma7/spksrc/actions/runs/6139502883

@th0ma7 th0ma7 deleted the gh-fix2-multi-publish branch September 10, 2023 21:38
@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 10, 2023

@hgy59 this is looking really good, thnx for your advices :)

I will now resume at deploying all python package update towards py311 and update the description of #5820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59 hgy59 approved these changes

Assignees

@th0ma7 th0ma7

Labels
status/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

github-action publishing uploads master package as well (i.e. python/ffmpeg)
2 participants
@th0ma7 @hgy59