version bump pngquant to v2.18.0

[zyrill]

Description

Updated pngquant from v2.17.0 to v2.18.0

TODO: switch to most up to date version based in rust, see https://lib.rs/crates/pngquant

Checklist

• Build rule all-supported completed successfully
• New installation of package completed successfully
• Package upgrade completed successfully (Manually install the package again)
• Package functionality was tested
• Any needed documentation is updated/created

Type of change

• Bug fix
• New Package
• Package update
• Includes small framework changes
• This change requires a documentation update (e.g. Wiki)

[hgy59]

dependency to tvheadend package

[zyrill]

dependency to tvheadend package

I started working on tvheadend and the intel-vaapi-driver dependency seems to be broken:

checking whether the C compiler works... no
configure: error: in "/spksrc/cross/intel-vaapi-driver/work-x64-7.2/intel-vaapi-driver-2.4.1":
configure: error: C compiler cannot create executables

and the config.log says:

configure:3770: $? = 0
configure:3759: /spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc -v >&5
Using built-in specs.
COLLECT_GCC=/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.2.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /home/ctng/.build/x86_64-pc-linux-gnu/src/gcc/configure --build=x86_64-build_pc-linux-gnu --host=x86_64-build_pc-linux-gnu --target=x86_64-pc-linux-gnu --prefix=/home/ctng/usr/local/x86_64-pc-linux-gnu --exec_prefix=/home/ctng/usr/local/x86_64-pc-linux-gnu --with-sysroot=/home/ctng/usr/local/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu/sys-root --enable-languages=c,c++,fortran --enable-__cxa_atexit --enable-libmudflap --enable-libgomp --enable-libssp --enable-libquadmath --enable-libquadmath-support --enable-libsanitizer --enable-libmpx --with-gmp=/home/ctng/.build/x86_64-pc-linux-gnu/buildtools --with-mpfr=/home/ctng/.build/x86_64-pc-linux-gnu/buildtools --with-mpc=/home/ctng/.build/x86_64-pc-linux-gnu/buildtools --with-isl=/home/ctng/.build/x86_64-pc-linux-gnu/buildtools --enable-lto --enable-threads=posix --enable-target-optspace --disable-plugin --with-libintl-prefix=/home/ctng/.build/x86_64-pc-linux-gnu/buildtools --disable-multilib --with-local-prefix=/home/ctng/usr/local/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu/sys-root --enable-long-long --enable-default-pie
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 12.2.0 (GCC) 
configure:3770: $? = 0
configure:3759: /spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc -V >&5
x86_64-pc-linux-gnu-gcc: error: unrecognized command-line option '-V'
x86_64-pc-linux-gnu-gcc: fatal error: no input files
compilation terminated.
configure:3770: $? = 1
configure:3759: /spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc -qversion >&5
x86_64-pc-linux-gnu-gcc: error: unrecognized command-line option '-qversion'; did you mean '--version'?
x86_64-pc-linux-gnu-gcc: fatal error: no input files
compilation terminated.
configure:3770: $? = 1
configure:3790: checking whether the C compiler works
configure:3812: /spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-gcc -I/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu/sys-root/usr/include -I/spksrc/cross/intel-vaapi-driver/work-x64-7.2/install/usr/local/intel-vaapi-driver/include  -I/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu/sys-root/usr/include -I/spksrc/cross/intel-vaapi-driver/work-x64-7.2/install/usr/local/intel-vaapi-driver/include  -L/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu/sys-root/lib -L/spksrc/cross/intel-vaapi-driver/work-x64-7.2/install/usr/local/intel-vaapi-driver/lib -Wl,--rpath-link,/spksrc/cross/intel-vaapi-driver/work-x64-7.2/install/usr/local/intel-vaapi-driver/lib -Wl,--rpath,/usr/local/intel-vaapi-driver/lib  conftest.c  >&5
/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/../lib/gcc/x86_64-pc-linux-gnu/12.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find /usr/local/intel-vaapi-driver/lib/libc.so.6: No such file or directory
/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/../lib/gcc/x86_64-pc-linux-gnu/12.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find /usr/local/intel-vaapi-driver/lib/libc_nonshared.a: No such file or directory
/spksrc/toolchain/syno-x64-7.2/work/x86_64-pc-linux-gnu/bin/../lib/gcc/x86_64-pc-linux-gnu/12.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find /usr/local/intel-vaapi-driver/lib/ld-linux-x86-64.so.2: No such file or directory
collect2: error: ld returned 1 exit status
configure:3816: $? = 1
configure:3854: result: no
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "intel_vaapi_driver"
| #define PACKAGE_TARNAME "intel-vaapi-driver"
| #define PACKAGE_VERSION "2.4.1"
| #define PACKAGE_STRING "intel_vaapi_driver 2.4.1"
| #define PACKAGE_BUGREPORT "https://github.com/intel/intel-vaapi-driver/issues/new"
| #define PACKAGE_URL "https://github.com/intel/intel-vaapi-driver"
| #define PACKAGE "intel-vaapi-driver"
| #define VERSION "2.4.1"
| #define INTEL_DRIVER_MAJOR_VERSION 2
| #define INTEL_DRIVER_MINOR_VERSION 4
| #define INTEL_DRIVER_MICRO_VERSION 1
| #define INTEL_DRIVER_PRE_VERSION 0
| /* end confdefs.h.  */
| 
| int
| main ()
| {
| 
|   ;
|   return 0;
| }
configure:3859: error: in '/spksrc/cross/intel-vaapi-driver/work-x64-7.2/intel-vaapi-driver-2.4.1':
configure:3861: error: C compiler cannot create executables
See 'config.log' for more details

[hgy59]

I started working on tvheadend and the intel-vaapi-driver dependency seems to be broken:

@zyrill thanks for this logs. It is an issue, that gcc in the DSM 7.2 toolchain fails, but DSM 7.1 toolchain succeeds.
You can just build for DSM 7.1 (and it will run on DSM 7.2 too).

In #6101 (comment) I mentioned that I couldn't remember a package that fails to build for DSM 7.2.
You helped my aged memory 😆

[hgy59]

@zyrill pngquant is now updated to v2.18.0 with #6143

If you want to update the tvheadend package, I propose to cooperate with the maintainer @th0ma7.

[th0ma7]

@zyrill tvheadend on its own isn't too bad to update but I normally do that in conjunction with ffmpeg, which is a large beast. @hgy59 I wanted to clear-up kernel, python (and now rust) before returning to package updates but this one has been lagging since quite a while so I'll switch on that for the next little while.

[hgy59]

TODO: switch to most up to date version based in rust, see https://lib.rs/crates/pngquant

I have a working solution for pngquant 3.0.3 but it is very tricky

• pngquant 3 needs rust build
• the issue building pngquant 3.0.3 was lacking imagequant-sys source (linked submodule not contained in pngquant archive)
• fixed the submodule issue with a cross/libimagequant-source package that gets linked into the submodule folder when building pngquant
• pngquant 3 fails to build when cross/zlib is built before (linking error). This can be fixed by depending on cross/zlib-ng, but works only, when cross/zlib is not already built by any other dependency like cross/libpng
  • this leads to ugly dependency order
  • this is not a problem with prebuilt ffmpeg (since we avoid to reuse zlib)
  • we already had a zlib issue with cross/bat, but this is gone with an update (Update zlib #6052)

I could provide a separate PR for this...

[hgy59]

I could provide a separate PR for this...

done with #6147

[hgy59]

@zyrill tvheadend on its own isn't too bad to update but I normally do that in conjunction with ffmpeg, which is a large beast. @hgy59 I wanted to clear-up kernel, python (and now rust) before returning to package updates but this one has been lagging since quite a while so I'll switch on that for the next little while.

As mentioned here tvheadend 4.4 is expected to be avalable soon (was planned for Q1 2024).

The latest 'stable' release (v4.2.8) was released in January 2019 and is now showing its age. As there are no plans for another v4.2 maintenance release and there is no direct upgrade path from v4.2 to v4.3/v4.4 we recommend all new installs use the current v4.3 'development' releases. These have been in a reliable state for several years and will soon become the new v4.4 stable release (eta in Q1/2024).)

[zyrill]

I'll defer to @th0ma7 's expertise... Thanks for all the support!