-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 3.10-3.11 updates #6200
python 3.10-3.11 updates #6200
Conversation
@th0ma7 I think I need your help. As you can see I tried to add the semantic-version package to the python-cross package, but it doesn't seem to help. I also tried putting it as part of python-native in another build, but that also didn't work. Thoughts? :) |
@Safihre There is this new issue that came up with inline assembly (tukaani-project/xz#121) for which there is already a fix available at tukaani-project/xz#136 that I ported into this PR. This will most likely be included in the next 5.6.3 release of That should already help so feel free to test this up. |
@Safihre having any PR opened so I can have a look at your changes for sabnzbd? |
I'm unable to trigger the python build errors using by Debian 12 container, merging #6183 and rebasing. |
@hgy59 and @Safihre I am unable to reproduce the issue locally. Further I'm unable to download the logs, it always fails before ending the download. Although, while trying to look at raw logs online I was able to notice (before my browser crashed) something related to Also, in order to limit build time I've killed-off Wait-and-see ... 🤷 |
@th0ma7 what about a dedicated PR with the xz fix? Another dedicated PR could update ncurses if mandatory... |
Excellent idea, I'll divide and conquer... And hopefully solve the python drama indeed. |
That's what I did with #6208, #6209 and #6210 Although, to be confirmed, but I'm guessing they may end-up being co-dependent to |
Yes, xz must be merged before the others And ncurses (AFAICR) triggers too many packages to complete within 5 hrs.... |
I tried to build python311 on this branch (with all wheels: WHEELS_TEST_ALL = 1)
|
@th0ma7 can you run a build with I did this with a former version of this PR (with python311 v3.11.5) and it worked when numpy was downgraded to 1.24.4 in additionally I downgraded setuptools in crossenv to v68.1.2, but I don't know whether it is requiered. |
My plan of action is to merge this pr as is to have a python update provided asap. Next is creating a new pr to have latest vs legacy wheel build environments or something similar. From my previous testing, up to the crossenv version used as an impact, in particular with older wheels. Also, part of the build issues found is the inability to pass toolchain files for cmake and meson based wheels. I believe i may have a solution for that. Edit: also, i intend to move all wheels currently into python31* spk under its own spk for more in-depth testing and easier update releases. |
I had not noticed your previous msg. I'll look into this while working on the subsequent pr. |
- downgrade numpy to v1.24.4 (python311, bazarr) - downgrade setuptools in crossenv and requirements-pure.txt to v68.1.2
@th0ma7 with the changes I just committed all wheels are built successfully in my local environment (except qoriq and ARMv7L that have an issue with rust that is probably only in my environment). |
Thnx for the commit, it does solves the immediate issue afaics. Although missing are:
All to say, maybe we still can get along with this round but clock is ticking before we need to make more fundamental changes, which i thought were needed now (with your commits, maybe for the next round). |
This reverts commit 0337438.
IMHO we should avoid fundamental changes in python311 and earlier. But for python312 we definitifly need a redesign of the cross wheel building process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
The ARMv7L issue with numpy should not stop us from going further.
Thanks for all your hard work both! |
Description
python 3.10-3.11 update + misc updates (xz, ncurses and svt-av1)
Fixes:
xz
sources no longer available from Debiancffi
1.17.0 and combination of newersetuptools
+pip
ffmpeg4
chromaprint
toffmpeg5
Re-divided into:
jackett
(jackett: Update from version 0.20.3990 to 0.22.534 #6211)native/libmysqlclient
(native/libmysqlclient: Fix build by using legacy cmake version #6212)xz
(xz: Update from version 5.6.1+really5.4.5 to 5.6.2 #6210) → depends on 6211, 6212, co-depends on 6215rutorrent
(rutorrent: Update from version 4.1.5 to 4.3.6 #6215) → co-depends on 6210ffmpeg4
+chromaprint
(Misc updates ffmpeg related #6208) → depends on 6210ncursesw
(ncursesw: Update from version 6.4 to 6.5 #6209)python311
(python 3.10-3.11 updates #6200) → depends on 6211, 6212, 6210, 6215, 6208ffmpeg6
opencl (Enable opencl on ffmpeg5-6 with DSM >= 7 #6166) → depends on 6210, 6208Checklist
all-supported
completed successfullyType of change