-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign dependency-list creation for github prepare action #6255
base: master
Are you sure you want to change the base?
Conversation
- add script to evaluate the dependencies - use new script in global Makefile for the dependency-list target - use global Makefile to create dependency-list in prepare.sh - avoid variables in DEPENDS definitions - make dependency-list.sh executable
@th0ma7 I wand to remove some obsolete dependencies. Can't we remove The same applies to Another one is native/cmake-legacy. This one is used with |
yes certainly. although a fair bit of testing may be needed along with adapting the framework. Just to manage expectations, I can certainly review code but my next focus really needs to be python...
That's probably an oversight as I updated our debian image during the time I was workding on intel opencl and this may have be there while using the older image. I'll check if that can be removed.
Feel free to remove that altogether. I've been trying to keep Although my 2 cents are, cmake native and legacy have proved to be quite useful. I'd be tempted to keep the code for newer cmake as i'm sure we'll hit this again later in a year or two. Also, I believe it would be time to start stripping off broken packages that never received any love since pre-DSM6, along with deleting them from our repository online. As well, I would remove all the older toolchains as no longer needed and clean-up the code related to tc and tk accordingly. This would reduce the framework weight for a bit and accelerated archs evaluation. |
@th0ma7 thank you for the feedback. I think I will hold back this PR for prior creating some smaller PRs for:
Then, later on, in this PR:
Finally, to remove OPTIONAL_DEPENDS, I would prefer separated PRs again. |
…n_dependency_list
- incr. package revision - avoid variable in DEPENDS (for SynoCommunity#6255) - restore ownership of package directories for SRM/DSM < 7
Description
This redesign speedsup the evaluation of dependent packages in github prepare action.
Instead of 3 to 5 minutes is now takes only a few seconds create the dependency list that is required.
Mandatory framework changes
$(SPK_NAME)
are not allowed in dependency definitions anymoreChecklist
all-supported
completed successfullyType of change