remove native nasm #6263
Open
remove native nasm #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove native nasm, it is a prerequisite in the dev. environment since update to debian 12 - remove native yasm - update related Makefiles
This reverts commit 2c4a9cb.
- change affected packages to trigger build
th0ma7
requested changes
Oct 9, 2024
Comment on lines
+21
to
+25
| NASM_BINARY = $(shell which nasm) | ||
| ifeq ($(NASM_BINARY),) | ||
| $(error nasm not found. Please install NASM assembler) | ||
| endif | ||
| ENV += AS=$(NASM_BINARY) |
There was a problem hiding this comment.
This is odd, the meson build system is probably cleaver enough to understand that AS=nasm isn't applicable other than on x86_64. But really there should be a pre-validation for x64 arch bfore this, like with other use-cases, as otherwise AS for all archs becomes superseeded with this irrelevant AS value.
There was a problem hiding this comment.
Found another issue in cross/zstd with ninja compile
When CMAKE_USE_NASM = 1 is not defined it uses nasm to create huf_decompress_amd64.S.o, but if it is defined, it uses gcc to create the file.
without CMAKE_USE_NASM = 1
[24/103] Building ASM object lib/CMakeFiles/libzstd_shared.dir/spksrc/cross/zstd-1.5.6_cmake/work-x64-7.1/zstd-1.5.6/lib/decompress/huf_decompress_amd64.S.o
with CMAKE_USE_NASM = 1
[24/103] Building C object lib/CMakeFiles/libzstd_shared.dir/spksrc/cross/zstd-1.5.6_cmake_nasm/work-x64-7.1/zstd-1.5.6/lib/decompress/huf_decompress_amd64.S.o
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Affected Libraries
Direct dependencies
Further findings
Affected Packages
By direct dependencies
Checklist
all-supportedcompleted successfullyType of change