Add options to discover initial color mode from URL param #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondeja
changed the title
initial_value_from_url_param option to UseColorModeOptionsinitial_value_from_url_param to UseColorModeOptions
mondeja
commented
Feb 11, 2024
maccesch
requested changes
Feb 11, 2024
mondeja
changed the title
initial_value_from_url_param to UseColorModeOptions
mondeja
force-pushed
the
initial_value_from_url_param
branch
2 times, most recently
from
f68bfb5 to
b8b3e78
Compare
mondeja
force-pushed
the
initial_value_from_url_param
branch
from
b8b3e78 to
3109a54
Compare
|
Now looks much better. |
mondeja
changed the title
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78
I'm not sure if this is the best way to implement it, but seems to work fine. Suggestions would be appreciated.