Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: scroll the precip graph to the present on mobile (issue #1) #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

citrusvanilla
Copy link

Programmatically scrolling the graph's wrapper container the number of pixels defined by $mobileBreakpoint (1000px) from the left edge ensures that the graph's canvas will always be anchored on its right side to its wrapper. This does not affect desktop container/canvas positioning in accordance with issue #1 acceptance criteria.

Though this addresses the issue, I personally don't think it provides the best UX as the y-axis tick labels ("inches of precip") are no longer visible by default. To address this you could place y-axis on both side of the chart though this also would provide poor UX as people are not accustomed to reading charts in this manner. A better option would be to reconfigure the layout of the chart for mobile screens altogether (using the same dependency, chartjs 2.7.x), which I can take a stab at if you are willing to revisit.

Also completely unrelated but I'm not a Ruby/Rails person but it seems that perhaps the official Ruby Docker images are pulling some dependencies without pinned versions, including some gem/lib called 'activesupport'. A major release, 7.0, seems to have been tagged in middle of December. The ruby 2.6 image appears to be pulling this 7.0 active support version which requires ruby 2.7+, so the Docker images won't build as is (unless I am missing something as I am using Mac OSX Big Sur). My local solution was to bump the ruby Docker image to 2.7 and make the associated change in the Gemfile.

@Syntaf
Copy link
Owner

Syntaf commented Jan 25, 2022

Hey @citrusvanilla - sorry for the late reply I somehow didn't get this notification. Appreciate the help! I need to do some K8s maintenance this week so I'll try and get this merged in and included.

@Syntaf Syntaf self-requested a review January 25, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants