Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escrowed SNX on V3 #123

Merged
merged 10 commits into from
Dec 22, 2024
Merged

Escrowed SNX on V3 #123

merged 10 commits into from
Dec 22, 2024

Conversation

peiman3
Copy link
Contributor

@peiman3 peiman3 commented Dec 20, 2024

Screenshot 2024-12-20 at 7 11 30 PM

@peiman3 peiman3 added the enhancement New feature or request label Dec 20, 2024
@peiman3 peiman3 requested a review from noisekit December 20, 2024 15:41
@peiman3 peiman3 self-assigned this Dec 20, 2024
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquidity-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2024 1:52pm

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 46.26866% with 36 lines in your changes missing coverage. Please review.

Project coverage is 62.10%. Comparing base (d3749a0) to head (331bf8c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...y/ui/src/components/Positions/LockedCollateral.tsx 5.88% 16 Missing ⚠️
liquidity/lib/useLocks/useLocks.ts 0.00% 12 Missing ⚠️
...idity/ui/src/components/Manage/CollateralStats.tsx 50.00% 3 Missing ⚠️
...idity/ui/src/components/Positions/PositionsRow.tsx 62.50% 3 Missing ⚠️
liquidity/ui/src/pages/Manage.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   66.33%   62.10%   -4.23%     
==========================================
  Files         263      264       +1     
  Lines        6449     6471      +22     
  Branches     2087     2104      +17     
==========================================
- Hits         4278     4019     -259     
- Misses       2171     2452     +281     
Files with missing lines Coverage Δ
liquidity/lib/ChangeStat/ChangeStat.tsx 100.00% <ø> (ø)
liquidity/lib/DebtAmount/DebtAmount.tsx 92.85% <ø> (ø)
...y/lib/useLiquidityPosition/useLiquidityPosition.ts 95.91% <100.00%> (+0.46%) ⬆️
...lib/useLiquidityPositions/useLiquidityPositions.ts 96.07% <100.00%> (+0.24%) ⬆️
liquidity/lib/useParams/useParams.ts 93.93% <ø> (ø)
liquidity/ui/src/components/Manage/PnlStats.tsx 100.00% <100.00%> (ø)
liquidity/ui/src/components/Withdraw/Withdraw.tsx 97.87% <100.00%> (+1.79%) ⬆️
liquidity/ui/src/pages/Manage.tsx 81.25% <33.33%> (-4.96%) ⬇️
...idity/ui/src/components/Manage/CollateralStats.tsx 80.95% <50.00%> (-8.53%) ⬇️
...idity/ui/src/components/Positions/PositionsRow.tsx 55.55% <62.50%> (-0.70%) ⬇️
... and 2 more

... and 13 files with indirect coverage changes

@noisekit noisekit merged commit 9556aee into master Dec 22, 2024
9 of 11 checks passed
@noisekit noisekit deleted the locked-collateral branch December 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants