Debt Repayer Front end Contract Base #54
Open
+382
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
noisekit
force-pushed
the
repayer-contract
branch
from
59f5298
to
6a5cea5
Compare
ProblematicP
force-pushed
the
baserepayerfixv1.2
branch
from
bed0e86
to
2ee1b3f
Compare
ProblematicP
force-pushed
the
baserepayerfixv1.2
branch
from
2ee1b3f
to
dbab858
Compare
ProblematicP
force-pushed
the
baserepayerfixv1.2
branch
from
dbab858
to
61d6d64
Compare
noisekit
force-pushed
the
repayer-contract
branch
from
1fa58d0
to
9b60090
Compare
noisekit
force-pushed
the
baserepayerfixv1.2
branch
from
68cacdb
to
dfadbcf
Compare
noisekit
requested changes
Nov 6, 2024
There was a problem hiding this comment.
-
Replace BaseTest inheritance with independent library functions
-
Remove boolean
_isContractargument from function. Either call it in test, or create separate helper to generate contract (dont believe we need this now anyway) -
remove
_ethBalanceargument and deal eth in test after creating address -
expectNoCallis no more explicit than expectCall with 0 count. Any additional helper function we add require to learn their syntax and if we can get away with using ONLY standard forge library - we should totally do that even if it leads to a bit of extra copypaste
ProblematicP
force-pushed
the
baserepayerfixv1.2
branch
from
a83da03
to
bd0a044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable things
-Want to use muldiv to multiply and divide rounding up but feel like overkill to import OZ for just this so doing the +1 method. Unsure how robust it is. Need to write an extreme test case to test it.
-Can prob user IERC20 instead of IUSDToken for erc related functions
-e2e tests not done yet