Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

similar reactions with different stoichiometry #347

Open
3 tasks
johan-gson opened this issue Jan 16, 2022 · 2 comments
Open
3 tasks

similar reactions with different stoichiometry #347

johan-gson opened this issue Jan 16, 2022 · 2 comments

Comments

@johan-gson
Copy link
Collaborator

Description of the issue:

Some reaction pairs are very similar, but with different stoichiometry, which is suspicious:
We should figure out which is right.
The third column is if they have the same GPR.
example (same GPR):
'2 ATP[c] + 2 H2O[c] + sulfate[c] => 2 ADP[c] + 2 H+[c] + 2 Pi[c] + sulfate[s]' 'ATP[c] + H2O[c] + sulfate[c] => ADP[c] + H+[c] + Pi[c] + sulfate[s]'

{'MAR01702'}    {'MAR02283'}    true   
{'MAR01857'}    {'MAR02290'}    true   
{'MAR01861'}    {'MAR02298'}    true   
{'MAR01913'}    {'MAR02304'}    true   
{'MAR04910'}    {'MAR04411'}    false  
{'MAR04912'}    {'MAR04411'}    false  
{'MAR05295'}    {'MAR05429'}    true   
{'MAR06057'}    {'MAR04411'}    false  
{'MAR06406'}    {'MAR01483'}    true   
{'MAR07633'}    {'MAR01442'}    true   
{'MAR07634'}    {'MAR00052'}    true   
{'MAR07635'}    {'MAR00065'}    true   
{'MAR07636'}    {'MAR00334'}    true   
{'MAR07637'}    {'MAR01555'}    true   
{'MAR07667'}    {'MAR00094'}    true   
{'MAR07681'}    {'MAR00058'}    true   
{'MAR07736'}    {'MAR00087'}    true   
{'MAR07737'}    {'MAR01396'}    true   
{'MAR07738'}    {'MAR01314'}    true   
{'MAR08922'}    {'MAR01518'}    true   
{'MAR08930'}    {'MAR01636'}    true   
{'MAR09603'}    {'MAR09873'}    true   
{'MAR09604'}    {'MAR09886'}    true   
{'MAR09613'}    {'MAR09886'}    false  
{'MAR00116'}    {'MAR02300'}    false  

Expected feature/value/output:

How the reaction/metabolite/gene/simulation result should look (cite literature if needed). PLEASE DELETE THIS LINE.

Current feature/value/output:

How the reaction/metabolite/gene/simulation actually looks in the main branch. PLEASE DELETE THIS LINE.

Reproducing these results:

Please attach any Matlab code used . PLEASE DELETE THIS LINE.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already

Note: replace [ ] with [X] to check the box. PLEASE DELETE THIS LINE

@Devlin-Moyer
Copy link
Collaborator

MAR04910, MAR04411, and MAR04912 were addressed in #568/#600. MAR06057 was not mentioned, but MAR04411 was removed in #600, and MAR04411 was the only potential duplicate of MAR06057 listed here.
MAR05295 was removed in #581
MAR06406 and MAR01483 were removed in #706
I haven't investigated any of the others beyond determining that no other issues or pull requests or anything mention them

@johan-gson
Copy link
Collaborator Author

Nice work cleaning this up, these issues have been around for some time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants