Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update na pi transport rxn gp rs #600

Merged
merged 2 commits into from
May 31, 2023
Merged

Fix/update na pi transport rxn gp rs #600

merged 2 commits into from
May 31, 2023

Conversation

haowang-bioinfo
Copy link
Member

This PR updates NA+/Pi transport reactions GPRs as referenced in Issue #568 (on behalf of @jreimertz)

Main improvements in this PR:

  • Removed reaction MAR04411
  • Removed reaction MAR05413
  • Added ENSG00000143324 (XPR1) to the GPR of MAR02351
  • Added ENSG00000144136 (SLC20A1) and ENSG00000168575 (SLC20A2) to the GPR of MAR04910

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@haowang-bioinfo
Copy link
Member Author

haowang-bioinfo commented May 31, 2023 •
edited
Loading

@jreimertz please check the changes of this PR that was made from the latest develop by picking your commits

@jreimertz
Copy link
Collaborator

Looks great! Thank you for your help with this

@haowang-bioinfo
Copy link
Member Author

Looks great! Thank you for your help with this

no problem - then approve if everything is ok

@haowang-bioinfo haowang-bioinfo merged commit d93940b into develop May 31, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/updateNaPiTransportRxnGPRs branch May 31, 2023 13:14
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 31, 2023
Closed
@haowang-bioinfo haowang-bioinfo mentioned this pull request Jun 17, 2023
Merged
@mihai-sysbio mihai-sysbio mentioned this pull request Jun 26, 2023
Merged
@Devlin-Moyer Devlin-Moyer mentioned this pull request Jun 17, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreimertz jreimertz jreimertz approved these changes

@feiranl feiranl Awaiting requested review from feiranl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haowang-bioinfo @jreimertz