fix: systematically add double quote to string elements in Yaml file #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Yaml file is updated by exporting with the new writeHumanYaml function.
- this optional feature allows to mute the notification messages while running the function
1. Enable automatic loading of yaml file from default location; 2. Mute notification messages while running the test.
JonathanRob
approved these changes
May 18, 2020
There was a problem hiding this comment.
Nice, glad to see we're moving toward a more standardized yaml format. Thank you @Hao-Chalmers and @dweindl for helping with this.
I tested and confirmed that the loaded model is identical to the model loaded from devel, and the functions work as described, so it looks good to me.
3 tasks
Merged
migp11
added a commit
to bsc-life/Human-GEM
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
This PR is to address the issue raised in #169
Yamlfile is updated by systematically enclosing string elements with double quote, through the modifiedwriteHumanYamlfunctionimportHumanYamlis adapted to the addition of double quote inYamlformattestYamlConversionis simplified by removing the input value and turning off notificationsYamlI hereby confirm that I have:
develas a target branch