Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove recon ids from reaction names #334

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

mihai-sysbio
Copy link
Member

Main improvements in this PR:

This PR removes the Recon ids from the reaction name field. As far as I can tell, these are anyway kept in reactions.tsv.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

@haowang-bioinfo
Copy link
Member

everything looks good

@mihai-sysbio I wonder how did you modify the 145 reaction names, manually or by regexp?

@mihai-sysbio
Copy link
Member Author

In VS Code I used Find and Replace with this regex

(- id: "MAR\d+"\n +- name: ")RE\d\d\d\d.

to replace with

$1

The way this works is to first finding all reaction (starting with MAR) where the name matches the RE.. pattern. Then, the first part is surrounded by ( ) to become a "captured" group, later to be referenced by $1. This basically replaces the entire find pattern with the first part of the find pattern, thus effectively deleting what is outside the ( ): only the RE.. name.

@mihai-sysbio mihai-sysbio merged commit ec9939a into develop Nov 9, 2021
@mihai-sysbio mihai-sysbio deleted the refactor/reaction-names branch November 9, 2021 06:55
@haowang-bioinfo haowang-bioinfo mentioned this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants