Fix: Amend #403 by merging additional model fields from duplicated rxns #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mihai-sysbio
approved these changes
Jul 27, 2022
|
nice work |
haowang-bioinfo
approved these changes
Jul 27, 2022
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
Continues the work in #403 which addressed #345.
This PR merges information from the
eccodesandrxnReferencesmodel fields from the removed duplicate reactions with those of the retained reactions.Note: I also inspected the
subSystems,rxnNames,rxnNotes, andrxnConfidenceScoresfields, but these were either identical or were not meaningful/appropriate to merge between the reaction pairs.I hereby confirm that I have:
developas a target branch