Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add subunit NDUFA7 to complex I #462

Merged
merged 4 commits into from
Jan 26, 2023
Merged

fix: add subunit NDUFA7 to complex I #462

merged 4 commits into from
Jan 26, 2023

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

johan-gson
johan-gson approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@johan-gson johan-gson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I noted that Jon's email in this file is out of date - has nothing to do with this PR, but it would be good to replace it, it no longer works.

feiranl
feiranl approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JonathanRob
JonathanRob approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@JonathanRob JonathanRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@haowang-bioinfo haowang-bioinfo merged commit 075737e into develop Jan 26, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/addCIsubunit branch January 26, 2023 16:52
@haowang-bioinfo haowang-bioinfo mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanRob JonathanRob JonathanRob approved these changes

@feiranl feiranl feiranl approved these changes

@johan-gson johan-gson johan-gson approved these changes

@mihai-sysbio mihai-sysbio Awaiting requested review from mihai-sysbio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haowang-bioinfo @JonathanRob @feiranl @johan-gson