Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify GPR rules of mitochondrial complexes II, IV, and V #489

Merged
merged 2 commits into from
Mar 3, 2023
Merged

fix: modify GPR rules of mitochondrial complexes II, IV, and V #489

merged 2 commits into from
Mar 3, 2023

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

This PR fixes GPR rules of mitochondrial complexes II, IV, and V, as proposed in #468, #469, #470

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@haowang-bioinfo
fix: update GPRs for OXPHOS complexes II, IV, V
a77d9a0 
-Update GPRs for OXPHOS complexes II, IV, V according to Complex Portal annotation
@haowang-bioinfo
fix-gene: update added genes to genes.tsv
c3faf5b
feiranl
feiranl approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo haowang-bioinfo merged commit d6f92a3 into develop Mar 3, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/modifyMitoComplexGPR branch March 3, 2023 12:10
This was referenced Mar 3, 2023
Closed
Closed
Closed
@haowang-bioinfo haowang-bioinfo mentioned this pull request Apr 5, 2023
Closed
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Merged
This was referenced Jun 6, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiranl feiranl feiranl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haowang-bioinfo @feiranl