Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pseudogenes, read through genes, and ones with only predicted functions #513

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Mar 25, 2023

Main improvements in this PR:

This PR removes 21 that are pseudogenes, read through genes, and ones with only predicted functions, as proposed in #510.

Note: all these genes are existed as isoenzymes in GPRs, so that their removal has no much impact to the model.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haowang-bioinfo haowang-bioinfo merged commit 5edef01 into develop Mar 28, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/removeGenesIssue510 branch March 28, 2023 16:14
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants