Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sodium Cotransport GPRs #655

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Fix Sodium Cotransport GPRs #655

merged 7 commits into from
Jul 6, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer commented Jun 20, 2023 •
edited
Loading

Main improvements in this PR:

Implements changes proposed in #569:

  • Removes MAR05310 for being a partial duplicate of MAR06380 but with the wrong stoichiometry
  • Merges annotations for MAR05310 in model/reactions.tsv with annotations for MAR06380
  • Changes GPR of MAR06380 to ENSG00000017483 or ENSG00000188338
  • Makes MAR06380 reversible
  • Removes MAR09887

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@haowang-bioinfo haowang-bioinfo mentioned this pull request Jul 5, 2023
Closed
7 tasks
@haowang-bioinfo haowang-bioinfo self-requested a review July 6, 2023 07:02
haowang-bioinfo
haowang-bioinfo approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super

@haowang-bioinfo haowang-bioinfo merged commit d3067b3 into develop Jul 6, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/sodium_cotransport_gprs branch July 6, 2023 13:59
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haowang-bioinfo haowang-bioinfo haowang-bioinfo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Devlin-Moyer @haowang-bioinfo