Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mitochondrial Glutathione Transport #723

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

@Devlin-Moyer Devlin-Moyer commented Nov 8, 2023

Main improvements in this PR:

As proposed in #722:

  • Removes MAR04940 and MAR06391
  • Adds new gene entries for SLC25A39 (ENSG00000013306) and SLC25A40 (ENSG00000075303)
  • Edits MAR08771 to be MAM02026c --> MAM02026m, GPR: ENSG00000013306 or ENSG00000075303, RHEA:74819
  • Merges annotations for MAR04940 and MAR06391 in reactions.tsv into those for MAR08771

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@Devlin-Moyer
Copy link
Collaborator Author

Devlin-Moyer commented Nov 8, 2023

The Ensembl website seems to have gone down (for me, at least) right after I got all the transcript and protein IDs for SLC25A39, so at the moment genes.tsv currently only has the Ensembl Gene ID and the one Ensembl Transcript ID that was on the HGNC page for SLC25A40; I can update it later, whenever I can actually connect to Ensembl
nevermind; got them off of GeneCards

@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented Nov 9, 2023

@Devlin-Moyer nice - all changes look good and didn't break anything

@haowang-bioinfo haowang-bioinfo merged commit af0862d into develop Nov 13, 2023
8 checks passed
@haowang-bioinfo haowang-bioinfo deleted the fix/glutathione_transport branch November 13, 2023 07:43
@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants