-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getBlast, importModel, replaceMets, ravenCobraWrapper / feat: getIndexes #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also more informative error message
This PR has been automatically tested with GH Actions. Here is the output of the tests: > Installation type Advanced (via git)
|
"Colon operands must be real scalars"
sparse matrix can give weird summary results when applying functions like min, max, mean etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
ravenCobraWrapper
handle empty rxnReferences from COBRA => RAVENreplaceMets
should not contract the whole model, only for the replaced metabolitesgetBlast
can handle paths containing spaces, or makes a custom temp path if required (solves Blast+ in RAVEN #506)importModel
with empty confidenceScores entriesconstructS
avoid warning about "Colon operands must be real scalars"randomSampling
should output the solutions as full matrix, as sparse matrices occassionally acts weird when using functions likemean
getIndexes
supportsecenzymes
,ecrxns
andecgenes
types, to query GECKO3model.ec
fieldsreadYAMLmodel
Instructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.