Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rat 1.0 #4

Merged
merged 14 commits into from
Oct 24, 2020
Merged

Rat 1.0 #4

merged 14 commits into from
Oct 24, 2020

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

Copy link
Contributor

@johan-gson johan-gson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look into details here

Copy link
Collaborator

@JonathanRob JonathanRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only minor comment: the README now references the contribution guidelines (CONTRIBUTING.md), but they're currently empty. Might be good to update this soon.

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Oct 23, 2020

@JonathanRob this file was provided empty by standard-GEM. The instructions in .standard-GEM.md in the File tree section cover this compulsory requirement, together with a few others, such as the presence of the yml file on branch devel.

@haowang-bioinfo haowang-bioinfo merged commit 01f947f into master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants