Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add standard-GEM.md #345

Merged
merged 1 commit into from
Jul 15, 2023
Merged

chore: add standard-GEM.md #345

merged 1 commit into from
Jul 15, 2023

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jul 9, 2023

Main improvements in this PR:

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected develop as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@edkerk edkerk added this to the 8.7.0 milestone Jul 9, 2023
@edkerk edkerk requested a review from mihai-sysbio July 9, 2023 17:56
Copy link
Member

@mihai-sysbio mihai-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

Human-GEM has opted to have a single .deprecated folder at the top level. I'm curious why is best on a day-to-day, and if perhaps consensus can be reached (it would be simpler to have the same behaviour across repositories).

@edkerk
Copy link
Member Author

edkerk commented Jul 11, 2023

To be honest, I think the best is not to have a deprecated at all, as old code & data is always available from earlier releases. But that would first require going through the current code & data to make sure removing it from coming and future releases does not break. Most likely this can indeed all be deleted. With that in mind, there shouldn't be anything added to these folders.

@edkerk edkerk merged commit 5f9df88 into develop Jul 15, 2023
@edkerk edkerk deleted the chore/standardGEM branch July 15, 2023 15:21
@mihai-sysbio
Copy link
Member

as old code & data is always available from earlier releases

Indeed, but it's not easy to do a recursive search in all previous releases for some lines of code that one vaguely knows of. In my view, code reuse is better facilitated if the deprecated files are kept. The discussion in Human-GEM took place here SysBioChalmers/Human-GEM#190 .

@edkerk
Copy link
Member Author

edkerk commented Jul 17, 2023

Thanks, very insightful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants