Fix compile warnings (#11)

* Fix compile warnings

* Fix imports in tests

src/bin/interactive/helpers.rs

@@ -1,6 +1,4 @@
-use crate::interactive::event::Event;
 use ratatui::layout::{Constraint, Direction, Layout};
-use termion::event::Key;
 
 // TODO: consider moving to some lib
 macro_rules! hashmap {
@@ -31,14 +29,6 @@ fn to_constraints(vals: Vec<u16>) -> Vec<Constraint> {
     vals.iter().map(|h| Constraint::Length(*h)).collect()
 }
 
-pub fn to_keys(text: &str) -> Vec<Key> {
-    text.chars().map(Key::Char).collect()
-}
-
-pub fn to_key_events(text: &str) -> Vec<Event<Key>> {
-    text.chars().map(|c| Event::Input(Key::Char(c))).collect()
-}
-
 pub fn to_string(vec: Vec<&str>) -> Vec<String> {
     vec.iter().map(|s| s.to_string()).collect()
 }

src/bin/interactive/interface.rs

@@ -227,10 +227,9 @@ fn columns_with_id_constraints() -> Vec<Constraint> {
 }
 
 #[cfg(test)]
-mod test {
+pub(crate) mod test {
     use crate::interactive::bookmarks_table::BookmarksTable;
     use crate::interactive::event::{Event, Events, Signal};
-    use crate::interactive::helpers::to_key_events;
     use crate::interactive::interface::{InputMode, Interface, SuppressedAction};
     use crate::interactive::table::TableItem;
     use bookmark_lib::registry::URLRegistry;
@@ -242,6 +241,14 @@ mod test {
     use std::path::{Path, PathBuf};
     use termion::event::Key;
 
+    pub fn to_keys(text: &str) -> Vec<Key> {
+        text.chars().map(Key::Char).collect()
+    }
+
+    pub fn to_key_events(text: &str) -> Vec<Event<Key>> {
+        text.chars().map(|c| Event::Input(Key::Char(c))).collect()
+    }
+
     fn fix_url_records() -> Vec<URLRecord> {
         vec![
             URLRecord::new("one", "one", "one", vec!["tag", "with space"]),
@@ -298,7 +305,7 @@ mod test {
             let interface = Interface::new(bookmarks_table).expect("Failed to initialize interface");
 
             (interface, cleaner)
-        };
+        }
     );
     () => (
         init!(vec![])

src/bin/interactive/modules/command.rs

@@ -1,5 +1,4 @@
 use crate::interactive::bookmarks_table::BookmarksTable;
-use crate::interactive::helpers::{horizontal_layout, vertical_layout};
 use crate::interactive::interface::InputMode;
 use crate::interactive::modules::{Draw, HandleInput, Module};
 use ratatui::layout::Rect;
@@ -188,7 +187,7 @@ impl Command {
 mod test {
     use crate::interactive::bookmarks_table::BookmarksTable;
     use crate::interactive::event::Events;
-    use crate::interactive::helpers::to_keys;
+    use crate::interactive::interface::test::to_keys;
     use crate::interactive::interface::InputMode;
     use crate::interactive::modules::command::{Command, DEFAULT_INFO_MESSAGE};
     use crate::interactive::modules::HandleInput;

src/bin/interactive/modules/delete.rs

@@ -3,7 +3,6 @@ use crate::interactive::interface::{InputMode, SuppressedAction};
 use crate::interactive::modules::{Draw, HandleInput, Module};
 use crate::interactive::widgets::rect::centered_fixed_rect;
 use bookmark_lib::types::URLRecord;
-use ratatui::backend::Backend;
 use ratatui::layout::Alignment;
 use ratatui::style::{Color, Modifier, Style};
 use ratatui::text::{Span, Text};

src/bin/interactive/modules/search.rs

@@ -1,8 +1,6 @@
 use crate::interactive::bookmarks_table::BookmarksTable;
-use crate::interactive::helpers::{horizontal_layout, vertical_layout};
 use crate::interactive::interface::InputMode;
 use crate::interactive::modules::{Draw, HandleInput, Module};
-use ratatui::backend::Backend;
 use ratatui::layout::Rect;
 use ratatui::style::Style;
 use ratatui::text::Text;
@@ -105,7 +103,7 @@ impl Search {
 mod test {
     use crate::interactive::bookmarks_table::BookmarksTable;
     use crate::interactive::event::Events;
-    use crate::interactive::helpers::to_keys;
+    use crate::interactive::interface::test::to_keys;
     use crate::interactive::modules::search::Search;
     use crate::interactive::modules::HandleInput;
     use bookmark_lib::registry::URLRegistry;

src/bin/interactive/url_table_item.rs

@@ -14,7 +14,6 @@ pub fn default_columns() -> Columns {
 
 #[derive(Clone, Debug)]
 pub struct URLItem {
-    visible: bool,
     url: URLRecord,
     row: Vec<String>,
 }
@@ -23,7 +22,6 @@ impl URLItem {
     pub fn new(record: URLRecord, cols: Option<&Columns>) -> URLItem {
         URLItem {
             url: record.clone(),
-            visible: true,
             row: url_to_row(
                 &record,
                 cols.unwrap_or(

src/lib/registry.rs

@@ -229,8 +229,8 @@ mod test {
         for tu in &all_urls {
             let result = registry
                 .create(
-                    tu.name.clone(),
-                    tu.url.clone(),
+                    tu.name,
+                    tu.url,
                     tu.group.clone(),
                     tu.tags.iter().map(|s| s.to_string()).collect(),
                 )
@@ -262,7 +262,7 @@ mod test {
 
         println!("List URLs from specific group...");
         let group_to_filter = "test";
-        let group_filter: Box<dyn Filter> = Box::new(GroupFilter::new(group_to_filter.clone()));
+        let group_filter: Box<dyn Filter> = Box::new(GroupFilter::new(group_to_filter));
 
         let urls = registry
             .list_urls(Some(group_filter.as_ref()), None)
@@ -274,7 +274,7 @@ mod test {
             .clone()
             .filter(|t| {
                 if let Some(group) = &t.group {
-                    return *group == group_to_filter.clone();
+                    return *group == group_to_filter;
                 }
                 false
             })
@@ -370,8 +370,8 @@ mod test {
     fn assert_urls_match(test_urls: &Vec<&TestUrl>, actual: &Vec<URLRecord>) {
         for tu in test_urls {
             let exists = actual.iter().any(|rec| {
-                rec.name == tu.name.clone()
-                    && rec.url == tu.url.clone()
+                rec.name == tu.name
+                    && rec.url == tu.url
                     && group_match(&tu.group, &rec.group)
                     && tags_match(&tu.tags, &rec.tags)
             });