Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distinct savelowerto/redirectlowerto file names #248

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

muzimuzhi
Copy link
Contributor

This PR makes the changes I suggested in 4918308#r128530467

Before, file name suffix _bspsave is used once in savelowerto doc example, and suffix _bspsave2 is used twice in savedelimiter doc examples.

Although using the same suffix is OK since each of the new files is input right after creation, using different suffixes in doc examples for different options and naming them consistently with a mono-increasing number suffix (like _bspsave, _bspsave2, _bspsave3, and maybe _bspsave4) is not a bad idea. (Sticking to the same suffix is also not bad.)

Update: Using distinct temp file names has the benefit of checking the verbatim-writing is working.

muzimuzhi referenced this pull request Sep 27, 2023
@T-F-S T-F-S merged commit 3b7e342 into T-F-S:master Sep 28, 2023
@T-F-S
Copy link
Owner

T-F-S commented Sep 28, 2023

Thank you for thorough reading. I will do as suggested.

@muzimuzhi muzimuzhi deleted the distinct-filenames branch September 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants