Add type definitions file index.d.ts #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luchanso
reviewed
Jan 3, 2022
index.d.ts
Outdated
|
|
||
| export function createBufferFrom(object: object): Buffer; | ||
|
|
||
| export function toDecimalString(buffer: Buffer, options: formatOption): string; |
|
Kudos, SonarCloud Quality Gate passed!
|
LGTM (and work for me), but I think repo owner not maintained this package anymore 😞 |
Luchanso
approved these changes
Jan 4, 2022
|
I think one of the good solution create types in definitely typed (maybe I'll latter do it): https://definitelytyped.org/guides/contributing.html |
but we can, I think this is the one of charm of open source, right? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the title, add type definitions file index.d.ts