-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/151- Ensure all scripts use UTC time instead of local time #203
Changes from all commits
cb960ef
f442925
92aa205
56b79db
5e32481
ae1d434
a83f3a8
5ed00b5
9ef4743
4b6b4c3
8fc3890
a58f426
414c029
007831d
9a4b81b
e554962
af6f6c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Curious as to what these changes are for? This doesn't fix UTC issues, please let me know what the changes are for. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did not modify any code here; I simply aligned the # characters, which resolved the following issue: calling "InvokeScript" with "4" argument(s): "The term '<#' is not recognized as the name of a cmdlet, function, |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes were made to this file that were not associated with this ticket, please revert these changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. didn't change |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
Large diffs are not rendered by default.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Before submitting a merge request, the code needs to be ran to makes sure your changes to the code base do not introduce errors like this. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be fine. Have you tested running this to make sure it works as intended? |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> | ||
<!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.1//EN" "report.dtd"[]> | ||
<report name="Pester (12/12/2024 00:57:03)"> | ||
<sessioninfo id="this" start="1733964927641" dump="1733965023306" /> | ||
<package name="scripts"> | ||
<class name="scripts/license" sourcefilename="license.ps1"> | ||
<method name="<script>" desc="()" line="1"> | ||
<counter type="INSTRUCTION" missed="2" covered="0" /> | ||
<counter type="LINE" missed="2" covered="0" /> | ||
<counter type="METHOD" missed="1" covered="0" /> | ||
</method> | ||
<counter type="INSTRUCTION" missed="2" covered="0" /> | ||
<counter type="LINE" missed="2" covered="0" /> | ||
<counter type="METHOD" missed="1" covered="0" /> | ||
<counter type="CLASS" missed="1" covered="0" /> | ||
</class> | ||
<sourcefile name="license.ps1"> | ||
<line nr="1" mi="1" ci="0" mb="0" cb="0" /> | ||
<line nr="3" mi="1" ci="0" mb="0" cb="0" /> | ||
<counter type="INSTRUCTION" missed="2" covered="0" /> | ||
<counter type="LINE" missed="2" covered="0" /> | ||
<counter type="METHOD" missed="1" covered="0" /> | ||
<counter type="CLASS" missed="1" covered="0" /> | ||
</sourcefile> | ||
<counter type="INSTRUCTION" missed="2" covered="0" /> | ||
<counter type="LINE" missed="2" covered="0" /> | ||
<counter type="METHOD" missed="1" covered="0" /> | ||
<counter type="CLASS" missed="1" covered="0" /> | ||
</package> | ||
<counter type="INSTRUCTION" missed="2" covered="0" /> | ||
<counter type="LINE" missed="2" covered="0" /> | ||
<counter type="METHOD" missed="1" covered="0" /> | ||
<counter type="CLASS" missed="1" covered="0" /> | ||
</report> |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ÿþ |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should not be in the repo, this is an output file from hawk being ran. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are good. No issues here.