Fix FlexFormTools callbackFunction #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration path from core deprecation #95254
as the only difference to the base method relies on a not existing parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During 12LTS migration an EXT:cal upgrade wizard failed because FlexFormTools8::cleanFlexFormXML_callBackFunction() created an exception.
After applying the migration path from https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.5/Deprecation-95254-TwoFlexFormToolsMethods.html to fix that exception the further calls relied on an
$pObj->traverseFlexFormXMLData_Datawhich I couldn't resolve to anything. So probably as of time of writing this was always null and probably thus nothing much was done in thatif. The remainder of the function is from the base function, so I propose to just delete it.While that resolves my updater issues, I don't have enough insight to prove that there are no race conditions from this, so please check this
¯\_(ツ)_/¯