Add build-requires pinning numpy to <2 #656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of numpy2.0, ta-lib is no longer installable (the build fails), as it's currently incompatible with numpy 2.x.
While that should be addressed too - I'm not sure it's a "quick fix" that can be done with just a few lines of code (or while keeping compatibility with older numpy versions).
i therefore think it's better to have a "quick fix" available so it's at least not breaking existing setups / installations.
Regular version-pinning is not relevant here - as it's the numpy version during build-time (a separate, isolated environment created while building a package) that's the problem currently.
Temporarily solves #655
Alternative workarounds: Disable build isolation.
To test this:
install ta-lib (regularly, without workaround) without this fix anytime after the numpy 2.x release (don't test while time-traveling, please) - notice it failing
Install with this fix - notice the build working again.