Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/DES-2309: Add virtual list rendering. #104

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Task/DES-2309: Add virtual list rendering. #104

merged 2 commits into from
Aug 29, 2022

Conversation

duckonomy
Copy link
Contributor

Overview:

Added virtual rendering of lists to speed up assets panel.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Added virtual rendering of long lists (>500) so that they are incrementally rendered rather than all at once.

Testing Steps:

  1. Test problematic map with Production environment
  2. Ensure that opening the assets panel does not cause the main slowdown

UI Photos:

Notes:

@duckonomy duckonomy marked this pull request as ready for review August 23, 2022 21:59
@duckonomy
Copy link
Contributor Author

@nathanfranklin Added canvas as the renderer. The map is now performing pretty well.

@nathanfranklin
Copy link
Collaborator

@nathanfranklin Added canvas as the renderer. The map is now performing pretty well.

awesome!

nathanfranklin
nathanfranklin approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM 👍

@duckonomy duckonomy merged commit 8b5b230 into master Aug 29, 2022
@nathanfranklin nathanfranklin deleted the task/DES-2309-speed-up-assets-panel branch December 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duckonomy @nathanfranklin