Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/des 2334 add testing linting #107

Merged
merged 11 commits into from
Sep 26, 2022

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Sep 20, 2022

Overview:

Add linting and testing to react client

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • add linting
  • add testing

Testing Steps:

  1. Run linting and tests

Notes:

TODO

  • tests

@nathanfranklin nathanfranklin marked this pull request as draft September 20, 2022 03:00
@nathanfranklin nathanfranklin marked this pull request as ready for review September 20, 2022 13:56
@nathanfranklin
Copy link
Collaborator Author

nathanfranklin commented Sep 20, 2022

@duckonomy , when reviewing, please check how things are linted. I'm not certain what we want but have it somewhat matching CEP (i.e. single quotes and semicolons)

Copy link
Contributor

@duckonomy duckonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanfranklin nathanfranklin merged commit 709cefb into master Sep 26, 2022
@nathanfranklin nathanfranklin deleted the task/DES-2334-add-testing-linting branch April 10, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants