Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-191: do not use headers for analytics information due to WG-191 #180

Merged

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Dec 7, 2023

Overview:

Disable added headers and use query params on single route instead. Headers can't be used due to https://tacc-main.atlassian.net/browse/WG-191 . The use of headers is left in code but commented out; to be re-used in WG-192 when we start using Taips V3.

See TACC-Cloud/geoapi#161 for more details.

Related Jira tickets:

Testing Steps:

See TACC-Cloud/geoapi#161

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦖

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not run locally, just reviewed in PR. One minor typo identified in the comments.

@nathanfranklin nathanfranklin merged commit 8eb641e into master Dec 15, 2023
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-191-do-not-use-headers-for-analytics-information branch December 15, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants