Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-212: use updated project create and project update routes #199

Merged
merged 9 commits into from
Feb 20, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Jan 23, 2024

Overview:

Updating project create (and project update) steps in the angular Hazmapper to match backend changes in TACC-Cloud/geoapi#173. Now the frontend just uses the single project endpoint (POST /projects) when creating a project. Now Hazmapper web client no longer makes any calls to TAPIS (for .hazmapper file, DesignSafe (for project metadata) or Geoapi (for adding two default base layers; see TACC-Cloud/geoapi#173 for more details.

Note, @tjgrafft and I also removed some unused code.

Related Jira tickets:

Testing Steps:

  1. See Task/WG-212: improve projects endpoint geoapi#173 for testing steps

UI Photos:

Notes:

  • drop some unused components and unused methods

@nathanfranklin nathanfranklin marked this pull request as draft January 23, 2024 21:25
Copy link
Contributor

@tjgrafft tjgrafft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally with backend. I was able to create maps (both in MyData and linked to DS projects). The hazmapper file was created correctly. The two default tile layers were added upon creation. I could see the metadata updating in the geoapi logs.

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice clean up!

@nathanfranklin nathanfranklin merged commit e48d9a3 into master Feb 20, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-212-improve-projects-endpoint branch February 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants