task/WG-253 - File Listing Component using Chonky #230
Conversation
There was a problem hiding this comment.
LGTM! Spoke with Shayan in DMs. There's a bug related to window size/media queries that caused a side effect for this PR. Previously, we were using the medium modal size, but here we're using XL. We will need to change the CSS rules in CreateMapModal to satisfy the new media queries/device sizes.
Does Chonky allow us to customize the icons and fade styles? Can we customize the selection pattern/image?
|
Master should have a fix for the .hazmapper overflow issue--so I think that will be resolved whenever you resolve conflicts and merge master with this branch |
shayanaijaz
force-pushed
the
task/WG-253--file-listing-component
branch
from
a8c843b to
559fcef
Compare
shayanaijaz
requested review from
nathanfranklin,
rstijerina and
sophia-massie
| path: | ||
| path || (selectedSystem?.id === myDataSystem?.id ? user?.username : ''), | ||
| offset: '0', | ||
| limit: '100', |
There was a problem hiding this comment.
do we need a follow on ticket for pagination?
| ? file.name.substring(file.name.lastIndexOf('.') + 1) | ||
| : undefined, | ||
| icon: file.type === 'dir' ? 'folder' : 'file', | ||
| selectable: |
There was a problem hiding this comment.
'selectable' is set to false for the files in CreateMapModal, but it's kinda hard to tell because of the styling. Maybe we can tweak that to make it clearer? Or in the short term, we could try using isHidden or just filter them out ourselves.
Overview:
Added a File Listing component using the Chonky library. Added this component to the Create Map modal with some dummy file data
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
TODO: