Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests and run in CI #33

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Fix unit tests and run in CI #33

merged 4 commits into from
Oct 27, 2020

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Oct 23, 2020 •
edited
Loading

Overview:

Fix unit tests

PR Status:

  • Ready.

Related Jira tickets:

Summary of Changes:

Testing Steps:

  1. Run tests locally

Notes:

@nathanfranklin nathanfranklin changed the title Fix test Fix unit tests and run in CI Oct 23, 2020
duckonomy
duckonomy approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@duckonomy duckonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nathanfranklin nathanfranklin merged commit 508bb78 into master Oct 27, 2020
@taoteg taoteg deleted the DES-1713-unit-tests branch July 6, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckonomy duckonomy duckonomy approved these changes

@reptillicus reptillicus Awaiting requested review from reptillicus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanfranklin @duckonomy