Task/DES-2006: Add ability to display custom styles and icons on map. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckonomy
changed the title
nathanfranklin
requested changes
Jun 23, 2021
There was a problem hiding this comment.
Works well. 👍
I made some test files for the current version of this branch https://www.designsafe-ci.org/data/browser/projects/3676202356334531051-242ac117-0001-012/ in version1 subfolder.
I have some suggestions that I'll ask about more specificaly on slack about:
- support for non-point geometries like polgons
- form of properties related to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Adds ability to detect style properties in a feature and display it on the map.
PR Status:
Related Jira tickets:
Summary of Changes:
Changed
leafletUtils.tsto add custom marker creators and changed some lines to remove eslint/tslint warnings.Testing Steps:
1. Try to put something like the below after line 150 inmap.component.ts2. Check that it loads the colors/icon3. Also try it without the icon property and changed.properties.customMarkerto'styled'4. This should show a circle marker with the style applied to it.Import files under
version 2from https://www.designsafe-ci.org/data/browser/projects/3676202356334531051-242ac117-0001-012/UI Photos:
Notes: