-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/DES-2001: Project links as observables (subscribe to project-user data). #67
Task/DES-2001: Project links as observables (subscribe to project-user data). #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍 I liked your ideas about changes to the modal that we discussed yesterday 💯
src/app/components/modal-create-project/modal-create-project.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can recheck when the backend PR is good to go but just wanted to leave a note of one things i saw 👍
src/app/components/modal-create-project/modal-create-project.component.ts
Show resolved
Hide resolved
Changes
New testing stepsTest with the related geoapi branch TACC-Cloud/geoapi#65
|
Newest changes address Tracy and Ellen's comments on usability.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍 Just a few comments to consider.
Sorry again for the late review 🙏 .
I think the only thing that really needs to be considered is the updating of map metadata (like. map name) and what we should do when that happens. Maybe things can be simpler as we aren't supporting "save as" anymore.
src/app/components/modal-create-project/modal-create-project.component.html
Outdated
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.html
Outdated
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.ts
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.ts
Outdated
Show resolved
Hide resolved
…omponent.ts Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
When saving/linking the map to a project, ensure that an observable project is also created.
Testing Steps:
UI Photos:
Notes: