-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ecep_cms #184
Merged
Merged
feat: ecep_cms #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the alpha 10 candidate (which is broken).
Without this trick[^1], VM servers would need to be updated to avoid broken snippets. Rush change prod, bad. Backwards-compatibility, better. [^1]: https://github.com/TACC/Core-CMS-Custom/blob/8e62799/docs/port-project.md#old-custom-templates-directory
These are just for sacing content, not loading.
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
taoteg
reviewed
Sep 1, 2023
ecep_cms/src/taccsite_custom/ecep_cms/static/ecep_cms/img/org_logos/favicon.ico
Outdated
Show resolved
Hide resolved
taoteg
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing here that is technically incorrect, all working fine. All my comments are based on consistency of organization across the projects. Take them with three grains of salt from the table of Marie Kondo...
…nto task/migrate-ecep
This was referenced Sep 1, 2023
@taoteg I've logged all your concerns as issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Migrate project from Core-CMS-Resources.
Related
Testing
UI
Many Screenshots