Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: Complete Core fix for section header colors #385

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 26, 2021

Requires

Overview

Set color of headings within a Sections to respect whether section is light or dark.

This is a more complete fix than #384.

Issues

After FP-1252 (cloning prod to pre-prod), this bug was discovered, which must be fixed before FP-1273 (deploy).

Screenshots

Headings are fixed. (Before, white text could appear on white background, or dark text on dark background.)

Pre-Prod Fixed Prod (Goal) Notes
Pre-Prod Prod banner text bkgd†

sysmon badge*

* The banner text background difference is a bug, a known issue, to fix in a separate PR.

† Warning badge for System Monitor maintenance is new orange color. This is a pre-existing fix, not a bug. production is using portal warning color, which Design did declare was for CMS.

Testing

Confirm that heading colors in pre-prod match production.

Last Recorded Testable Build:

@wesleyboar
Copy link
Member Author

wesleyboar commented Oct 26, 2021

Merging because:

  1. Frontera CMS may deployed this week, and should not cause such obvious bugs as these. I was only just able to realize these bugs, yesterday, after FP-1252 was completed.
  2. Related fix Hotfix: Frontera: White Text for Home Banner H3's Core-CMS-Resources#100 was merged.
  3. Taking advantage of admin privilege.

Related submod branch was merged to main.
@wesleyboar wesleyboar merged commit 8b9256b into main Oct 26, 2021
@wesleyboar wesleyboar deleted the hotfix/wrong-heading-text-colors-on-home-page branch October 26, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant