Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1544: Annotate Lightweight Tags #465

Closed
wants to merge 8 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 12, 2022

Overview

Add script to annotate lightweight tags.

Related

Changes

  • Add script.
  • Ignore its output (used to manually check if script worked).

Testing

  1. Run the new script.
  2. Confirm no errors.
  3. Compare the two output files.
  4. Confirm the "after" output difference has:
    • two dates per entry
    • no other content is changed

The whitespace in output files is different… sorry 🤷‍♂️ . Ideas?

Notes

After this process is approved, only then should we actually push the tags to origin. (Otherwise, origin might lose data from incorrect solution.)

@wesleyboar wesleyboar added the proposal Proposal or request for new task label May 4, 2022
@rstijerina
Copy link
Member

How do you propose we make sure tags are added moving forwards in the release process?

@wesleyboar
Copy link
Member Author

wesleyboar commented May 5, 2022

@rstijerina Manually run this script upon each release. Not great, I know.

I really feel this is a problem GitHub should solve (feedback).

@wesleyboar
Copy link
Member Author

Proposal declined.

It's not worth changing our build process to accommodate this:

  • benefit is a string in a comment on for devs who will rarely see it
  • it's a problem GitHub should solve
  • we want to move to a new build process anyway

@wesleyboar wesleyboar closed this May 25, 2022
@wesleyboar
Copy link
Member Author

This is apparently already part of main since v3.12.0-beta.4: e043d45.

@wesleyboar wesleyboar deleted the task/FP-1544-annotate-lightweight-tags branch November 13, 2023 20:44
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script was eventually restored. It's available in main currently. Permalink for the v4.9.0 one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposal or request for new task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants